Skip to content

Conversation

@PhilippStamp
Copy link

@PhilippStamp PhilippStamp commented Dec 26, 2025

Hey. I added a german translation for the subdomains plugin (and fixed my typos).

Summary by CodeRabbit

  • New Features
    • Added German language localization for the subdomain management interface with translated strings for domain limits, creation controls, naming conventions, API token guidance, and related configuration options.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 26, 2025

📝 Walkthrough

Walkthrough

A new German language translation file has been added to the subdomains module. The file provides localized string mappings for subdomain management UI elements, including domain counts, limits, actions, and API token guidance, returning a PHP associative array of key-value pairs.

Changes

Cohort / File(s) Summary
Localization - German Subdomain Strings
subdomains/lang/de/strings.php
New translation file providing German localized strings for subdomain management features (domain/subdomain limits, creation, naming, and API token help text).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A fluffy friend hops with delight,
New German words now burning bright,
Subdomains speak in Deutsch so fine,
Mit Übersetzungen—the code will shine!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[subdomains] added german translation' directly and clearly describes the main change: adding German language translations for the subdomains plugin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
subdomains/lang/de/strings.php (1)

9-12: Consider using a German word for "Limit".

The English word "Limit" is used throughout these translations. While it's commonly understood in German technical contexts, you might want to consider using native German alternatives such as "Grenze", "Obergrenze", or "Begrenzung" for better localization. However, using "Limit" is also acceptable and provides consistency with international terminology.

🔎 Example with German word "Grenze"
-    'limit' => 'Limit',
-    'change_limit' => 'Limit anpassen',
-    'limit_changed' => 'Limit angepasst',
-    'limit_reached' => 'Subdomainlimit erreicht',
+    'limit' => 'Grenze',
+    'change_limit' => 'Grenze anpassen',
+    'limit_changed' => 'Grenze angepasst',
+    'limit_reached' => 'Subdomain-Grenze erreicht',
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 81e4cdd and 9f45509.

📒 Files selected for processing (1)
  • subdomains/lang/de/strings.php
🔇 Additional comments (1)
subdomains/lang/de/strings.php (1)

1-3: LGTM!

The file structure is correct for a PHP translation file.

'name' => 'Name',

'api_token' => 'Cloudflare API Token',
'api_token_help' => 'Das Token benötigt Leseberechtigung für Zone.Zone und Schreibberechtigung für Zone.Dns. Für eine verstärkte Sicherheit, können mit "Zone Resources" bestimmte Domains ausgeschlossen werden. Mit "Client IP Adress Filtering" kannst du die Panel-IP freigeben.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

Cloudflare API token Client IP filtering feature official name

💡 Result:

The official name is "Client IP address range filtering" (also referred to as "Client IP Address Filtering"). [1][2]

Sources:
[1] Cloudflare Developers — Restrict tokens (Client IP address range filtering).
[2] Cloudflare support/docs references to "Client IP Address Filtering".


Fix grammatical error and correct feature name spelling.

The help text has two issues:

  1. Grammatical error: The comma after "Sicherheit" is unnecessary. In German, no comma should precede "können" in this sentence structure.
  2. Spelling error: "Adress" should be "Address" — this matches Cloudflare's official feature name "Client IP Address Filtering".
-    'api_token_help' => 'Das Token benötigt Leseberechtigung für Zone.Zone und Schreibberechtigung für Zone.Dns. Für eine verstärkte Sicherheit, können mit "Zone Resources" bestimmte Domains ausgeschlossen werden. Mit "Client IP Adress Filtering" kannst du die Panel-IP freigeben.',
+    'api_token_help' => 'Das Token benötigt Leseberechtigung für Zone.Zone und Schreibberechtigung für Zone.Dns. Für eine verstärkte Sicherheit können mit "Zone Resources" bestimmte Domains ausgeschlossen werden. Mit "Client IP Address Filtering" kannst du die Panel-IP freigeben.',
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
'api_token_help' => 'Das Token benötigt Leseberechtigung für Zone.Zone und Schreibberechtigung für Zone.Dns. Für eine verstärkte Sicherheit, können mit "Zone Resources" bestimmte Domains ausgeschlossen werden. Mit "Client IP Adress Filtering" kannst du die Panel-IP freigeben.',
'api_token_help' => 'Das Token benötigt Leseberechtigung für Zone.Zone und Schreibberechtigung für Zone.Dns. Für eine verstärkte Sicherheit können mit "Zone Resources" bestimmte Domains ausgeschlossen werden. Mit "Client IP Address Filtering" kannst du die Panel-IP freigeben.',
🤖 Prompt for AI Agents
In subdomains/lang/de/strings.php around line 18, the help text contains a
grammatical error and a misspelled feature name: remove the comma after
"Sicherheit" so the clause reads fluidly without a comma before "können" and
correct "Adress" to "Address" so the feature reads "Client IP Address
Filtering"; update the string accordingly to preserve surrounding punctuation
and capitalization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant