-
Notifications
You must be signed in to change notification settings - Fork 16
[subdomains] added german translation #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughA new German language translation file has been added to the subdomains module. The file provides localized string mappings for subdomain management UI elements, including domain counts, limits, actions, and API token guidance, returning a PHP associative array of key-value pairs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
subdomains/lang/de/strings.php (1)
9-12: Consider using a German word for "Limit".The English word "Limit" is used throughout these translations. While it's commonly understood in German technical contexts, you might want to consider using native German alternatives such as "Grenze", "Obergrenze", or "Begrenzung" for better localization. However, using "Limit" is also acceptable and provides consistency with international terminology.
🔎 Example with German word "Grenze"
- 'limit' => 'Limit', - 'change_limit' => 'Limit anpassen', - 'limit_changed' => 'Limit angepasst', - 'limit_reached' => 'Subdomainlimit erreicht', + 'limit' => 'Grenze', + 'change_limit' => 'Grenze anpassen', + 'limit_changed' => 'Grenze angepasst', + 'limit_reached' => 'Subdomain-Grenze erreicht',
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
subdomains/lang/de/strings.php
🔇 Additional comments (1)
subdomains/lang/de/strings.php (1)
1-3: LGTM!The file structure is correct for a PHP translation file.
| 'name' => 'Name', | ||
|
|
||
| 'api_token' => 'Cloudflare API Token', | ||
| 'api_token_help' => 'Das Token benötigt Leseberechtigung für Zone.Zone und Schreibberechtigung für Zone.Dns. Für eine verstärkte Sicherheit, können mit "Zone Resources" bestimmte Domains ausgeschlossen werden. Mit "Client IP Adress Filtering" kannst du die Panel-IP freigeben.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
Cloudflare API token Client IP filtering feature official name
💡 Result:
The official name is "Client IP address range filtering" (also referred to as "Client IP Address Filtering"). [1][2]
Sources:
[1] Cloudflare Developers — Restrict tokens (Client IP address range filtering).
[2] Cloudflare support/docs references to "Client IP Address Filtering".
Fix grammatical error and correct feature name spelling.
The help text has two issues:
- Grammatical error: The comma after "Sicherheit" is unnecessary. In German, no comma should precede "können" in this sentence structure.
- Spelling error: "Adress" should be "Address" — this matches Cloudflare's official feature name "Client IP Address Filtering".
- 'api_token_help' => 'Das Token benötigt Leseberechtigung für Zone.Zone und Schreibberechtigung für Zone.Dns. Für eine verstärkte Sicherheit, können mit "Zone Resources" bestimmte Domains ausgeschlossen werden. Mit "Client IP Adress Filtering" kannst du die Panel-IP freigeben.',
+ 'api_token_help' => 'Das Token benötigt Leseberechtigung für Zone.Zone und Schreibberechtigung für Zone.Dns. Für eine verstärkte Sicherheit können mit "Zone Resources" bestimmte Domains ausgeschlossen werden. Mit "Client IP Address Filtering" kannst du die Panel-IP freigeben.',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 'api_token_help' => 'Das Token benötigt Leseberechtigung für Zone.Zone und Schreibberechtigung für Zone.Dns. Für eine verstärkte Sicherheit, können mit "Zone Resources" bestimmte Domains ausgeschlossen werden. Mit "Client IP Adress Filtering" kannst du die Panel-IP freigeben.', | |
| 'api_token_help' => 'Das Token benötigt Leseberechtigung für Zone.Zone und Schreibberechtigung für Zone.Dns. Für eine verstärkte Sicherheit können mit "Zone Resources" bestimmte Domains ausgeschlossen werden. Mit "Client IP Address Filtering" kannst du die Panel-IP freigeben.', |
🤖 Prompt for AI Agents
In subdomains/lang/de/strings.php around line 18, the help text contains a
grammatical error and a misspelled feature name: remove the comma after
"Sicherheit" so the clause reads fluidly without a comma before "können" and
correct "Adress" to "Address" so the feature reads "Client IP Address
Filtering"; update the string accordingly to preserve surrounding punctuation
and capitalization.
Hey. I added a german translation for the subdomains plugin (and fixed my typos).
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.