-
Notifications
You must be signed in to change notification settings - Fork 54
Remove unused changelog #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request removes changelog generation infrastructure from the project. The CHANGELOG.md file is deleted, its two entries removed from .dockerignore, and all related changelog extraction and publishing steps are removed from the release workflow. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/release.yaml (2)
65-93: Consider upgrading tosoftprops/action-gh-releasefor asset uploads.The workflow uses the deprecated
actions/upload-release-asset@v1action. Thesoftprops/action-gh-releaseaction (already used at line 58) can handle asset uploads directly via itsfilesparameter, simplifying the workflow.🔎 Example consolidation
- name: Create release id: create_release uses: softprops/action-gh-release@v1 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: draft: true prerelease: ${{ contains(github.ref, 'rc') || contains(github.ref, 'beta') || contains(github.ref, 'alpha') }} files: | dist/wings_linux_amd64 dist/wings_linux_arm64 checksums.txtThis would replace the create release step and all three upload steps.
20-23: Use the latest stable patch version of Go instead.Go 1.24.7 is valid and exists; however, Go 1.24.10 (released 2025-11-05) is a newer patch release in the same minor version. Consider updating to 1.24.10 to include recent security and bug fixes.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.dockerignore(1 hunks).github/workflows/release.yaml(1 hunks)CHANGELOG.md(0 hunks)
💤 Files with no reviewable changes (1)
- CHANGELOG.md
🔇 Additional comments (2)
.dockerignore (1)
1-54: LGTM! Cleanup aligns with PR objectives.The removal of
CHANGELOG.mdandwings-api.pawentries from.dockerignoreis consistent with the deletion of the changelog infrastructure from the project..github/workflows/release.yaml (1)
56-63: Release body will be empty.With the removal of
body_pathand the changelog extraction steps, GitHub releases created by this workflow will have empty descriptions. This appears intentional given the PR's goal to remove changelog infrastructure, but ensure this aligns with your release communication strategy.
I also removed
CHANGELOG.mdandwings-api.pawfrom the.dockerignore.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.