Skip to content

Conversation

@lajczi
Copy link

@lajczi lajczi commented Dec 21, 2025

I also removed CHANGELOG.md and wings-api.paw from the .dockerignore.

Summary by CodeRabbit

  • Chores
    • Updated Docker configuration to include previously ignored files in builds.
    • Simplified release automation workflow by removing changelog extraction and modification steps.
    • Modified release process to focus on checksum generation only.

✏️ Tip: You can customize this high-level summary in your review settings.

@lajczi lajczi requested a review from a team as a code owner December 21, 2025 08:40
@coderabbitai
Copy link

coderabbitai bot commented Dec 21, 2025

Walkthrough

The pull request removes changelog generation infrastructure from the project. The CHANGELOG.md file is deleted, its two entries removed from .dockerignore, and all related changelog extraction and publishing steps are removed from the release workflow.

Changes

Cohort / File(s) Summary
Changelog deprecation
CHANGELOG.md
File entirely deleted; all version history and release notes removed
Workflow and configuration updates
\.dockerignore, \.github/workflows/release\.yaml
Removed CHANGELOG.md from Docker ignore patterns; removed "Extract changelog" step, simplified "Create checksum and add to changelog" to "Create checksum", and removed body_path reference from release creation step

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Straightforward deletion of changelog file and removal of related references across config files
  • No logic changes or conditional flow modifications
  • Verify all workflow steps that referenced RELEASE_CHANGELOG have been properly removed

Poem

🐰 The changelog once did grow so long,
With versions sung in mighty song,
But now we shed that weighty weight,
And let the workflow automate!
No more to track what came before—
Simplicity we now adore! 📝

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the CHANGELOG.md file and related changelog processing from the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/release.yaml (2)

65-93: Consider upgrading to softprops/action-gh-release for asset uploads.

The workflow uses the deprecated actions/upload-release-asset@v1 action. The softprops/action-gh-release action (already used at line 58) can handle asset uploads directly via its files parameter, simplifying the workflow.

🔎 Example consolidation
- name: Create release
  id: create_release
  uses: softprops/action-gh-release@v1
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
  with:
    draft: true
    prerelease: ${{ contains(github.ref, 'rc') || contains(github.ref, 'beta') || contains(github.ref, 'alpha') }}
    files: |
      dist/wings_linux_amd64
      dist/wings_linux_arm64
      checksums.txt

This would replace the create release step and all three upload steps.


20-23: Use the latest stable patch version of Go instead.

Go 1.24.7 is valid and exists; however, Go 1.24.10 (released 2025-11-05) is a newer patch release in the same minor version. Consider updating to 1.24.10 to include recent security and bug fixes.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29935d6 and 81ab07c.

📒 Files selected for processing (3)
  • .dockerignore (1 hunks)
  • .github/workflows/release.yaml (1 hunks)
  • CHANGELOG.md (0 hunks)
💤 Files with no reviewable changes (1)
  • CHANGELOG.md
🔇 Additional comments (2)
.dockerignore (1)

1-54: LGTM! Cleanup aligns with PR objectives.

The removal of CHANGELOG.md and wings-api.paw entries from .dockerignore is consistent with the deletion of the changelog infrastructure from the project.

.github/workflows/release.yaml (1)

56-63: Release body will be empty.

With the removal of body_path and the changelog extraction steps, GitHub releases created by this workflow will have empty descriptions. This appears intentional given the PR's goal to remove changelog infrastructure, but ensure this aligns with your release communication strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant