Transfer staking rewards from the treasury. #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
reviewed
Sep 11, 2025
Member
ebma
left a comment
ebma
left a comment
There was a problem hiding this comment.
Looks good to me 👍 we just need to add the type also to the mock in pallets/parachain-staking/src/mock.rs
Contributor
Author
|
Thanks @ebma, didn't mark for review as I was testing. It went well as the event |
ebma
approved these changes
Sep 11, 2025
Member
ebma
left a comment
ebma
left a comment
There was a problem hiding this comment.
Let's apply the naming suggestion of clippy and then get this merged ✅
Contributor
Author
|
@ebma pinging for re-approve, all tests seem to be okay now. |
ebma
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace mint operation when claiming rewards with a transfer from the treasury account.