Skip to content

Conversation

@gsexton
Copy link
Contributor

@gsexton gsexton commented Mar 8, 2025

This pull requests changes the LineSet from gpioioctl to implement gpio.Group. It pretty much had the requirements but some of the types were subtly different.

@maruel
Copy link
Member

maruel commented Mar 9, 2025

Do I understand we need to roll conn first?

@gsexton
Copy link
Contributor Author

gsexton commented Mar 9, 2025

Do I understand we need to roll conn first?

I've updated go.mod to reference the current version of conn.

Separately, I'll need to update devices to use this new version of host to for the hd44780 work go to in. I know this can be done by referencing commits. Is your preference to do a release, or to have the go.mod reference the commit ID we need?

@codecov
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 27.2%. Comparing base (28c0c75) to head (6be3152).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
gpioioctl/lineset.go 0.0% 19 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.0%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (27.2%) is below the target coverage (60.0%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##            main     #67     +/-   ##
=======================================
- Coverage   27.2%   27.2%   -0.0%     
=======================================
  Files         96      96             
  Lines      11822   11827      +5     
=======================================
  Hits        3220    3220             
- Misses      8467    8472      +5     
  Partials     135     135             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

func (ls *LineSet) ByName(name string) *LineSetLine {

// ByName returns a Line by name from the LineSet. To cast the returned value
// to a LineSet line, use:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be better as an example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, you're recommending duplicating the example on ByName() to the doc for ByOffset()?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about creating a toy example in example_test.go but it was really just a nit, don't bother.

@maruel
Copy link
Member

maruel commented Mar 10, 2025

Feel free to patch .codecov.yml to lower the minimum coverage required.

@maruel
Copy link
Member

maruel commented Mar 10, 2025

.. or bypass the check

@gsexton gsexton merged commit 02c216f into periph:main Mar 15, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants