Add warning for superfluous ignore comments (#427) #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ileitch
force-pushed
the
issue-427
branch
5 times, most recently
from
b1172a2 to
58c05d4
Compare
Detect and report when `// periphery:ignore` comments are unnecessary because the declaration is actually referenced and would not have been reported as unused. This helps identify outdated ignore comments that should be removed, similar to SwiftLint's superfluous_disable_command rule. Superfluous ignore command results are excluded from baselines since they're warnings about unnecessary comments, not unused code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect and report when
// periphery:ignorecomments are unnecessary because the declaration is actually referenced and would not have been reported as unused.This helps identify outdated ignore comments that should be removed, similar to SwiftLint's superfluous_disable_command rule.