Fix how chat recent actions filter selection logic works #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the channel system messages filter.
Channel -> Administrators -> Recent actions -> All actions (screen title)
If you deselect one of the action types, and then tap on the 'All actions' switch, all actions become deselected. 'Done' button becomes inactive, preventing you to apply the filter. I made a fix for this bug.
There is another bug in the channel system messages filter.
Channel -> Administrators -> Recent actions -> All actions (screen title)
If you just open the screen, and try to deselect one of the admins in the 'ADMINS' section, the FIRST TAP will do nothing. You can then tap on the 'All admins' switch above, and it also will do nothing.
I fixed the issue, so that the admins filter always works as expected.