Patch 1 #4
Open
Patch 1 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` @mock(a=["(aa)"]) def foo(self, str_a='aaa()aaa') ``` think of this case, the old regex `("syn region pythonVars start="(" end=")" contained contains=pythonParameters transparent keepend )` will take ) in aaa() as the end of region pythonVars
foo(self, str_a='aaa()aaa):')
fix () in pythonParameters
on line 108, added a period (.) after the colon (:) and before the asterisk (*) to make the expression :.* (match anything after the colon) instead of :* (match any number of colons) Previously, this presented an issue where whitespace after a function definition followed by a comment starting with # would cause the entire comment and several following tokens to be classified as identifiers instead of their respective true classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem with line 108 by adding a period (.) after the colon (:) and before the asterisk ( * ) where instead of :.* \n matching any number of characters until the end of a line, it was :*\n, which matches any number of colons to the end of a line. This causes the entire few lines after the function definition to be classified as an identifier instead until something breaks that expression.