Enable raise_on_missing_only in development #6495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think we don't raise on unknown options... which means we can pass this option even if Plug the version is not yet released. Let's see if CI agrees. |
brendon9x
force-pushed
the
static_plug_raise_on_missing
branch
from
fcbf902 to
864b02c
Compare
Configure Plug.Static with raise_on_missing_only: code_reloading?() to help developers catch missing entries in static_paths() during development. This prevents the common trap where files like favicon.svg return 404 because they aren't properly declared in the :only list (often because they digested paths). Part of the fix for: phoenixframework#6203
brendon9x
force-pushed
the
static_plug_raise_on_missing
branch
from
864b02c to
a62435f
Compare
Member
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure Plug.Static with raise_on_missing_only: code_reloading?() to help developers catch missing entries in static_paths() during development. This prevents the common trap where files like favicon.svg return 404 because they aren't properly declared in the :only list (often because they digested paths).
Part of the fix for: #6203
Requires: elixir-plug/plug#1286