Skip to content

Conversation

@kianmeng
Copy link
Contributor

Changes:

  • bump actions/checkout
  • do not run duplicated jobs on push/pull request at the same time
  • update test to handle ets result between OTP 28/27 and earlier

Changes:
- bump actions/checkout
- do not run duplicated jobs on push/pull request at the same time
- update test to handle ets result between OTP 28/27 and earlier
Comment on lines 19 to 20
if: github.event_name == 'pull_request' || github.ref != format('refs/heads/{0}', github.event.pull_request.head.ref)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I understand the condition properly. I found the following which seems to make more sense to me: https://github.com/orgs/community/discussions/57827#discussioncomment-6579237

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the rule: 5c32781, see if I miss out anything.

@kianmeng kianmeng requested a review from SteffenDE November 25, 2025 15:17
@josevalim josevalim merged commit 2a2e861 into phoenixframework:main Nov 25, 2025
2 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants