Skip to content

Conversation

@fain182
Copy link
Collaborator

@fain182 fain182 commented Nov 23, 2025

Add support for collecting dependencies from PHP 8.4 property hooks:

  • Handle typed parameters in set hooks (e.g., set(MyClass $value))
  • Dependencies from expressions within hook bodies (new, static calls, etc.) are already collected by the AST traverser

Fixes #515

Add support for collecting dependencies from PHP 8.4 property hooks:
- Handle typed parameters in set hooks (e.g., set(MyClass $value))
- Dependencies from expressions within hook bodies (new, static calls, etc.)
  are already collected by the AST traverser

Fixes #515
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.76%. Comparing base (069d374) to head (43c9270).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #538   +/-   ##
=========================================
  Coverage     97.75%   97.76%           
- Complexity      615      618    +3     
=========================================
  Files            79       79           
  Lines          1780     1786    +6     
=========================================
+ Hits           1740     1746    +6     
  Misses           40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlessandroMinoccheri
Copy link
Member

@fain182 I suggest adding few lines in the documentation too.

@fain182
Copy link
Collaborator Author

fain182 commented Jan 1, 2026

I don't think we need to add anything to the README for this. We don't document individual PHP language features that we support - the README doesn't have a section listing things like 'we support attributes' or 'we support enums' or 'we support readonly classes'. The expectation is that we support all PHP syntax.

@fain182 fain182 merged commit 22b2b68 into main Jan 1, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collect dependencies define in property hooks

5 participants