Skip to content

Conversation

@iMattPro
Copy link
Contributor

@iMattPro iMattPro commented May 6, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.29%. Comparing base (630411f) to head (fdb62c7).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage     50.29%   50.29%           
  Complexity       46       46           
=========================================
  Files             4        4           
  Lines           171      171           
=========================================
  Hits             86       86           
  Misses           85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rxu
Copy link

rxu commented May 7, 2025

The problem here seems to be that migrator class is constructed with an empty $tools array, which should be migrator tools collection instead. Not sure why it only fails on Windows. Thus, migrator can't find any tools (like config etc) and just fails to install migrations.
Example (with config tool injected):
https://github.com/phpbb/phpbb/blob/1b2ac50cfda0957db3f45138b5a7f7fb1b4148a9/tests/dbal/migrator_test.php#L57-L75

@iMattPro iMattPro merged commit 185deec into master May 8, 2025
37 checks passed
@iMattPro iMattPro deleted the iMattPro-patch-1 branch May 8, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants