Skip to content

Conversation

@veewee
Copy link
Contributor

@veewee veewee commented Oct 23, 2025

No description provided.

@veewee veewee requested a review from Copilot October 23, 2025 07:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prevents falling back to simple base types when dealing with simple enums. When a property has enum values defined, the code should now use the generated enum type instead of falling back to the base type (e.g., string).

  • Added condition to check for presence of enums before falling back to base type
  • Added test case to verify enum types are preserved even for simple base types

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Phpro/SoapClient/CodeGenerator/Model/Property.php Added enum check to prevent fallback to base type when enums are present
test/PhproTest/SoapClient/Unit/CodeGenerator/Model/PropertyTest.php Added test case for simple base types with enums to verify the fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@veewee veewee merged commit 59b1e32 into phpro:v4.x Oct 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant