Feedback! #83
Open
Feedback! #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, what you guys have made is incredibly impressive. This was a very challenging and ambitious project and you should be very proud of what you have made. You clearly have an advanced understanding of tools we have taught you and were able to learn cutting edge tools like redux, web sockets, and webpack on you own. That being said, it looks like performance on your server is still hampered by HMR, I really hope you guys fix your deployment and production configuration and get it published on a real server because I think you guys are this close to having a tool that could be really useful for real people. At the very least having it actually hosted some where will look awesome on your portfolios. I can't wait to see where this goes next and what other projects you guys work on.
-Best
Austin
ps: The documentation is better but still could use work