getShapeFromStyle should read shape properties before taking 'arrow' … #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
This is for #166 .
The issue was that getShapeFromStyle was returning the "arrow" choice in case there was nothing in style variable, which is normal when we only specify an endShape. Having an arrow as chosenEndShape in createShapeObj caused the shape returned to be undefined, and in cascade, it generated this broken figure.
I believe that before choosing this default shape, the function should check if an arrow or a circle was specified in the shape.
Let me know what you think and take care :)
Thomas