Skip to content

cluster: support deploying resource manager service #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xhebox merged 3 commits into from
Jan 5, 2026
Merged

cluster: support deploying resource manager service #2659

xhebox merged 3 commits into from
Jan 5, 2026
+709 −99

Conversation

@okJiang
Copy link
Member

@okJiang okJiang commented Dec 26, 2025 •
edited
Loading

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
Details 
./bin/tiup-cluster deploy ms1 nightly topo-ms-min.yaml --user root -i ~/.ssh/id_ed25519

+ Detect CPU Arch Name
  - Detecting node 10.2.12.124 Arch info ... Done

+ Detect CPU OS Name
  - Detecting node 10.2.12.124 OS info ... Done
Please confirm your topology:
Cluster type:    tidb
Cluster name:    ms1
Cluster version: nightly
Role              Host         Ports                 OS/Arch       Directories
----              ----         -----                 -------       -----------
pd                10.2.12.124  2379/2380             linux/x86_64  /tmp/tiup-deploy/pd-2379,/tmp/tiup-data/pd-2379
tso               10.2.12.124  3379                  linux/x86_64  /tmp/tiup-deploy/tso-3379,/tmp/tiup-data/tso-3379
scheduling        10.2.12.124  3378                  linux/x86_64  /tmp/tiup-deploy/scheduling-3378,/tmp/tiup-data/scheduling-3378
resource-manager  10.2.12.124  3377                  linux/x86_64  /tmp/tiup-deploy/resource-manager-3377,/tmp/tiup-data/resource-manager-3377
tikv              10.2.12.124  20160/20180           linux/x86_64  /tmp/tiup-deploy/tikv-20160,/tmp/tiup-data/tikv-20160
tidb              10.2.12.124  4000/10080            linux/x86_64  /tmp/tiup-deploy/tidb-4000
prometheus        10.2.12.124  9090/9115/9100/12020  linux/x86_64  /tmp/tiup-deploy/prometheus-9090,/tmp/tiup-data/prometheus-9090
Attention:
    1. If the topology is not what you expected, check your yaml file.
    2. Please confirm there is no port/directory conflicts in same host.
Do you want to continue? [y/N]: (default=N) y
+ Generate SSH keys ... Done
+ Download TiDB components
+ Download TiDB components
  - Download pd:nightly (linux/amd64) ... Done
  - Download tikv:nightly (linux/amd64) ... Done
  - Download tidb:nightly (linux/amd64) ... Done
  - Download prometheus:nightly (linux/amd64) ... Done
  - Download node_exporter: (linux/amd64) ... Done
  - Download blackbox_exporter: (linux/amd64) ... Done
+ Initialize target host environments
  - Prepare 10.2.12.124:22 ... Done
+ Deploy TiDB instance
  - Copy pd -> 10.2.12.124 ... Done
  - Copy tso -> 10.2.12.124 ... Done
  - Copy scheduling -> 10.2.12.124 ... Done
  - Copy resource-manager -> 10.2.12.124 ... Done
  - Copy tikv -> 10.2.12.124 ... Done
  - Copy tidb -> 10.2.12.124 ... Done
  - Copy prometheus -> 10.2.12.124 ... Done
  - Deploy node_exporter -> 10.2.12.124 ... Done
  - Deploy blackbox_exporter -> 10.2.12.124 ... Done
+ Copy certificate to remote host
+ Init instance configs
  - Generate config pd -> 10.2.12.124:2379 ... Done
  - Generate config tso -> 10.2.12.124:3379 ... Done
  - Generate config scheduling -> 10.2.12.124:3378 ... Done
  - Generate config resource-manager -> 10.2.12.124:3377 ... Done
  - Generate config tikv -> 10.2.12.124:20160 ... Done
  - Generate config tidb -> 10.2.12.124:4000 ... Done
  - Generate config prometheus -> 10.2.12.124:9090 ... Done
+ Init monitor configs
  - Generate config node_exporter -> 10.2.12.124 ... Done
  - Generate config blackbox_exporter -> 10.2.12.124 ... Done
Enabling component pd
        Enabling instance 10.2.12.124:2379
download https://tiup-mirrors.pingcap.com/pd-v9.0.0-beta.2.pre-nightly-linux-amd64.tar.gz 7.16 MiB / 60.38 MiB 11.85% 0 B/s                                 Enable instance 10.2.12.124:2379 success
Enabling component tso
        Enabling instance 10.2.12.124:3379
download https://tiup-mirrors.pingcap.com/prometheus-v9.0.0-beta.2.pre-nightly-linux-amd64.tar.gz 9.16 MiB / 126.00 MiB 7.27% 0 B/s                         Enable instance 10.2.12.124:3379 success
Enabling component scheduling
        Enabling instance 10.2.12.124:3378
download https://tiup-mirrors.pingcap.com/tikv-v9.0.0-beta.2.pre-nightly-linux-amd64.tar.gz 1008.00 KiB / 303.01 MiB 0.32% 0 B/s                            Enable instance 10.2.12.124:3378 success
Enabling component resource-manager
        Enabling instance 10.2.12.124:3377
download https://tiup-mirrors.pingcap.com/prometheus-v9.0.0-beta.2.pre-nightly-linux-amd64.tar.gz 9.16 MiB / 126.00 MiB 7.27% 0 B/s                         Enable instance 10.2.12.124:3377 success
Enabling component tikv
        Enabling instance 10.2.12.124:20160
download https://tiup-mirrors.pingcap.com/pd-v9.0.0-beta.2.pre-nightly-linux-amd64.tar.gz 7.16 MiB / 60.38 MiB 11.85% 0 B/s                                 Enable instance 10.2.12.124:20160 success
Enabling component tidb
        Enabling instance 10.2.12.124:4000
download https://tiup-mirrors.pingcap.com/tikv-v9.0.0-beta.2.pre-nightly-linux-amd64.tar.gz 1008.00 KiB / 303.01 MiB 0.32% 0 B/s                            Enable instance 10.2.12.124:4000 success
Enabling component prometheus
        Enabling instance 10.2.12.124:9090
download https://tiup-mirrors.pingcap.com/pd-v9.0.0-beta.2.pre-nightly-linux-amd64.tar.gz 7.16 MiB / 60.38 MiB 11.85% 0 B/s                                 Enable instance 10.2.12.124:9090 success
Enabling component node_exporter
        Enabling instance 10.2.12.124
download https://tiup-mirrors.pingcap.com/prometheus-v9.0.0-beta.2.pre-nightly-linux-amd64.tar.gz 9.16 MiB / 126.00 MiB 7.27% 0 B/s                         Enable 10.2.12.124 success
Enabling component blackbox_exporter
        Enabling instance 10.2.12.124
download https://tiup-mirrors.pingcap.com/pd-v9.0.0-beta.2.pre-nightly-linux-amd64.tar.gz 7.16 MiB / 60.38 MiB 11.85% 0 B/s                                 Enable 10.2.12.124 success
Cluster `ms1` deployed successfully, you can start it with command: `tiup-cluster start ms1 --init`
jiangxianjie@192 ~/c/o/tiup (support-rm)> ./bin/tiup-cluster start ms1
Starting cluster ms1...
+ [ Serial ] - SSHKeySet: privateKey=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/ssh/id_rsa, publicKey=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/ssh/id_rsa.pub
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [ Serial ] - StartCluster
Starting component pd
        Starting instance 10.2.12.124:2379
        Start instance 10.2.12.124:2379 success
Starting component tso
        Starting instance 10.2.12.124:3379
        Start instance 10.2.12.124:3379 success
Starting component scheduling
        Starting instance 10.2.12.124:3378
        Start instance 10.2.12.124:3378 success
Starting component resource-manager
        Starting instance 10.2.12.124:3377
        Start instance 10.2.12.124:3377 success
Starting component tikv
        Starting instance 10.2.12.124:20160
        Start instance 10.2.12.124:20160 success
Starting component tidb
        Starting instance 10.2.12.124:4000
        Start instance 10.2.12.124:4000 success
Starting component prometheus
        Starting instance 10.2.12.124:9090
        Start instance 10.2.12.124:9090 success
Starting component node_exporter
        Starting instance 10.2.12.124
        Start 10.2.12.124 success
Starting component blackbox_exporter
        Starting instance 10.2.12.124
        Start 10.2.12.124 success
+ [ Serial ] - UpdateTopology: cluster=ms1
Started cluster `ms1` successfully
jiangxianjie@192 ~/c/o/tiup (support-rm)> mysql -uroot -h10.2.12.124 -P4000
Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 2399141892
Server version: 8.0.11-TiDB-v9.0.0-beta.2.pre-952-g62ee49c TiDB Server (Apache License 2.0) Community Edition, MySQL 8.0 compatible

Copyright (c) 2000, 2025, Oracle and/or its affiliates.

Oracle is a registered trademark of Oracle Corporation and/or its
affiliates. Other names may be trademarks of their respective
owners.

Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.

mysql> exit
Bye
jiangxianjie@192 ~/c/o/tiup (support-rm)> ./bin/tiup-cluster upgrade ms1 nightly
Before the upgrade, it is recommended to read the upgrade guide at https://docs.pingcap.com/tidb/stable/upgrade-tidb-using-tiup and finish the preparation steps.
This operation will upgrade tidb nightly cluster ms1 (with a concurrency of 5) to nightly:
will upgrade and restart component "                 pd" to "nightly",
will upgrade and restart component "                tso" to "nightly",
will upgrade and restart component "         scheduling" to "nightly",
will upgrade and restart component "   resource-manager" to "nightly",
will upgrade and restart component "               tikv" to "nightly",
will upgrade and restart component "               tidb" to "nightly",
will upgrade and restart component "         prometheus" to "nightly",
will upgrade component     "node-exporter" to "",
will upgrade component "blackbox-exporter" to "".
Do you want to continue? [y/N]:(default=N) y
Upgrading cluster...
+ [ Serial ] - SSHKeySet: privateKey=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/ssh/id_rsa, publicKey=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/ssh/id_rsa.pub
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [ Serial ] - Download: component=prometheus, version=nightly, os=linux, arch=amd64
+ [ Serial ] - Download: component=pd, version=nightly, os=linux, arch=amd64
+ [ Serial ] - Download: component=tidb, version=nightly, os=linux, arch=amd64
+ [ Serial ] - Download: component=tikv, version=nightly, os=linux, arch=amd64
download monitored
  - Download node_exporter: (linux/amd64) ... Done
  - Download blackbox_exporter: (linux/amd64) ... Done
+ [ Serial ] - Mkdir: host=10.2.12.124, directories='/tmp/tiup-data/scheduling-3378'
+ [ Serial ] - Mkdir: host=10.2.12.124, directories='/tmp/tiup-data/tikv-20160'
+ [ Serial ] - Mkdir: host=10.2.12.124, directories='/tmp/tiup-data/resource-manager-3377'
+ [ Serial ] - Mkdir: host=10.2.12.124, directories='/tmp/tiup-data/tso-3379'
+ [ Serial ] - Mkdir: host=10.2.12.124, directories='/tmp/tiup-data/pd-2379'
+ [ Serial ] - BackupComponent: component=pd, currentVersion=nightly, remote=10.2.12.124:/tmp/tiup-deploy/scheduling-3378
+ [ Serial ] - BackupComponent: component=tikv, currentVersion=nightly, remote=10.2.12.124:/tmp/tiup-deploy/tikv-20160
+ [ Serial ] - BackupComponent: component=pd, currentVersion=nightly, remote=10.2.12.124:/tmp/tiup-deploy/resource-manager-3377
+ [ Serial ] - BackupComponent: component=pd, currentVersion=nightly, remote=10.2.12.124:/tmp/tiup-deploy/tso-3379
+ [ Serial ] - BackupComponent: component=pd, currentVersion=nightly, remote=10.2.12.124:/tmp/tiup-deploy/pd-2379
+ [ Serial ] - CopyComponent: component=pd, version=nightly, remote=10.2.12.124:/tmp/tiup-deploy/tso-3379 os=linux, arch=amd64
+ [ Serial ] - CopyComponent: component=pd, version=nightly, remote=10.2.12.124:/tmp/tiup-deploy/pd-2379 os=linux, arch=amd64
+ [ Serial ] - CopyComponent: component=pd, version=nightly, remote=10.2.12.124:/tmp/tiup-deploy/resource-manager-3377 os=linux, arch=amd64
+ [ Serial ] - CopyComponent: component=pd, version=nightly, remote=10.2.12.124:/tmp/tiup-deploy/scheduling-3378 os=linux, arch=amd64
+ [ Serial ] - CopyComponent: component=tikv, version=nightly, remote=10.2.12.124:/tmp/tiup-deploy/tikv-20160 os=linux, arch=amd64
+ [ Serial ] - InitConfig: cluster=ms1, user=root, host=10.2.12.124, path=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache/tso-3379.service, deploy_dir=/tmp/tiup-deploy/tso-3379, data_dir=[/tmp/tiup-data/tso-3379], log_dir=/tmp/tiup-log/tso-3379, cache_dir=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache
+ [ Serial ] - InitConfig: cluster=ms1, user=root, host=10.2.12.124, path=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache/scheduling-3378.service, deploy_dir=/tmp/tiup-deploy/scheduling-3378, data_dir=[/tmp/tiup-data/scheduling-3378], log_dir=/tmp/tiup-log/scheduling-3378, cache_dir=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache
+ [ Serial ] - InitConfig: cluster=ms1, user=root, host=10.2.12.124, path=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache/pd-2379.service, deploy_dir=/tmp/tiup-deploy/pd-2379, data_dir=[/tmp/tiup-data/pd-2379], log_dir=/tmp/tiup-log/pd-2379, cache_dir=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache
+ [ Serial ] - InitConfig: cluster=ms1, user=root, host=10.2.12.124, path=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache/resource-manager-3377.service, deploy_dir=/tmp/tiup-deploy/resource-manager-3377, data_dir=[/tmp/tiup-data/resource-manager-3377], log_dir=/tmp/tiup-log/resource-manager-3377, cache_dir=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache
+ [ Serial ] - Mkdir: host=10.2.12.124, directories=''
+ [ Serial ] - BackupComponent: component=tidb, currentVersion=nightly, remote=10.2.12.124:/tmp/tiup-deploy/tidb-4000
+ [ Serial ] - CopyComponent: component=tidb, version=nightly, remote=10.2.12.124:/tmp/tiup-deploy/tidb-4000 os=linux, arch=amd64
+ [ Serial ] - Mkdir: host=10.2.12.124, directories='/tmp/tiup-data/prometheus-9090'
+ [ Serial ] - BackupComponent: component=prometheus, currentVersion=nightly, remote=10.2.12.124:/tmp/tiup-deploy/prometheus-9090
+ [ Serial ] - CopyComponent: component=prometheus, version=nightly, remote=10.2.12.124:/tmp/tiup-deploy/prometheus-9090 os=linux, arch=amd64
+ [ Serial ] - InitConfig: cluster=ms1, user=root, host=10.2.12.124, path=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache/tidb-4000.service, deploy_dir=/tmp/tiup-deploy/tidb-4000, data_dir=[], log_dir=/tmp/tiup-log/tidb-4000, cache_dir=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache
+ [ Serial ] - InitConfig: cluster=ms1, user=root, host=10.2.12.124, path=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache/prometheus-9090.service, deploy_dir=/tmp/tiup-deploy/prometheus-9090, data_dir=[/tmp/tiup-data/prometheus-9090], log_dir=/tmp/tiup-log/prometheus-9090, cache_dir=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache
+ [ Serial ] - InitConfig: cluster=ms1, user=root, host=10.2.12.124, path=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache/tikv-20160.service, deploy_dir=/tmp/tiup-deploy/tikv-20160, data_dir=[/tmp/tiup-data/tikv-20160], log_dir=/tmp/tiup-log/tikv-20160, cache_dir=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/config-cache
deploy monitored
  - Deploy node_exporter -> 10.2.12.124 ... Done
  - Deploy blackbox_exporter -> 10.2.12.124 ... Done
refresh monitored config
  - Generate config node_exporter -> 10.2.12.124 ... Done
  - Generate config blackbox_exporter -> 10.2.12.124 ... Done
+ [ Serial ] - UpgradeCluster
Upgrading component pd
        Executing pre-upgrade command on 10.2.12.124

        Restarting instance 10.2.12.124:2379
        Restart instance 10.2.12.124:2379 success
        Executing post-upgrade command on 10.2.12.124

Upgrading component tso
        Executing pre-upgrade command on 10.2.12.124

        Restarting instance 10.2.12.124:3379
        Restart instance 10.2.12.124:3379 success
        Executing post-upgrade command on 10.2.12.124

Upgrading component scheduling
        Executing pre-upgrade command on 10.2.12.124

        Restarting instance 10.2.12.124:3378
        Restart instance 10.2.12.124:3378 success
        Executing post-upgrade command on 10.2.12.124

Upgrading component resource-manager
        Executing pre-upgrade command on 10.2.12.124

        Restarting instance 10.2.12.124:3377
        Restart instance 10.2.12.124:3377 success
        Executing post-upgrade command on 10.2.12.124

Upgrading component tikv
        Executing pre-upgrade command on 10.2.12.124

        Restarting instance 10.2.12.124:20160
        Restart instance 10.2.12.124:20160 success
        Executing post-upgrade command on 10.2.12.124

Upgrading component tidb
        Executing pre-upgrade command on 10.2.12.124

        Restarting instance 10.2.12.124:4000
        Restart instance 10.2.12.124:4000 success
        Executing post-upgrade command on 10.2.12.124

Upgrading component prometheus
        Executing pre-upgrade command on 10.2.12.124

        Restarting instance 10.2.12.124:9090
        Restart instance 10.2.12.124:9090 success
        Executing post-upgrade command on 10.2.12.124

Stopping component node_exporter
        Stopping instance 10.2.12.124
        Stop 10.2.12.124 success
Stopping component blackbox_exporter
        Stopping instance 10.2.12.124
        Stop 10.2.12.124 success
Starting component node_exporter
        Starting instance 10.2.12.124
        Start 10.2.12.124 success
Starting component blackbox_exporter
        Starting instance 10.2.12.124
        Start 10.2.12.124 success
Upgraded cluster `ms1` successfully
jiangxianjie@192 ~/c/o/tiup (support-rm)> git push origin support-rm
Enumerating objects: 58, done.
Counting objects: 100% (58/58), done.
Delta compression using up to 8 threads
Compressing objects: 100% (31/31), done.
Writing objects: 100% (31/31), 7.58 KiB | 7.58 MiB/s, done.
Total 31 (delta 25), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (25/25), completed with 24 local objects.
remote: 
remote: Create a pull request for 'support-rm' on GitHub by visiting:
remote:      https://github.com/okJiang/tiup/pull/new/support-rm
remote: 
To https://github.com/okJiang/tiup.git
 * [new branch]        support-rm -> support-rm
jiangxianjie@192 ~/c/o/tiup (support-rm)> ./bin/tiup-cluster destroy ms1

  ██     ██  █████  ██████  ███    ██ ██ ███    ██  ██████
  ██     ██ ██   ██ ██   ██ ████   ██ ██ ████   ██ ██
  ██  █  ██ ███████ ██████  ██ ██  ██ ██ ██ ██  ██ ██   ███
  ██ ███ ██ ██   ██ ██   ██ ██  ██ ██ ██ ██  ██ ██ ██    ██
   ███ ███  ██   ██ ██   ██ ██   ████ ██ ██   ████  ██████

This operation will destroy tidb nightly cluster ms1 and its data.
Are you sure to continue?
(Type "Yes, I know my cluster and data will be deleted." to continue)
: Yes, I know my cluster and data will be deleted.
Destroying cluster...
+ [ Serial ] - SSHKeySet: privateKey=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/ssh/id_rsa, publicKey=/Users/jiangxianjie/.tiup/storage/cluster/clusters/ms1/ssh/id_rsa.pub
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [Parallel] - UserSSH: user=root, host=10.2.12.124
+ [ Serial ] - StopCluster
Stopping component prometheus
        Stopping instance 10.2.12.124
        Stop prometheus 10.2.12.124:9090 success
Stopping component tidb
        Stopping instance 10.2.12.124
        Stop tidb 10.2.12.124:4000 success
Stopping component tikv
        Stopping instance 10.2.12.124
        Stop tikv 10.2.12.124:20160 success
Stopping component resource-manager
        Stopping instance 10.2.12.124
        Stop resource-manager 10.2.12.124:3377 success
Stopping component scheduling
        Stopping instance 10.2.12.124
        Stop scheduling 10.2.12.124:3378 success
Stopping component tso
        Stopping instance 10.2.12.124
        Stop tso 10.2.12.124:3379 success
Stopping component pd
        Stopping instance 10.2.12.124
        Stop pd 10.2.12.124:2379 success
Stopping component node_exporter
        Stopping instance 10.2.12.124
        Stop 10.2.12.124 success
Stopping component blackbox_exporter
        Stopping instance 10.2.12.124
        Stop 10.2.12.124 success
+ [ Serial ] - DestroyCluster
Destroying component prometheus
        Destroying instance 10.2.12.124
Destroy 10.2.12.124 finished
- Destroy prometheus paths: [/tmp/tiup-log/prometheus-9090 /tmp/tiup-deploy/prometheus-9090 /etc/systemd/system/prometheus-9090.service /tmp/tiup-data/prometheus-9090]
Destroying component tidb
        Destroying instance 10.2.12.124
Destroy 10.2.12.124 finished
- Destroy tidb paths: [/tmp/tiup-log/tidb-4000 /tmp/tiup-deploy/tidb-4000 /etc/systemd/system/tidb-4000.service]
Destroying component tikv
        Destroying instance 10.2.12.124
Destroy 10.2.12.124 finished
- Destroy tikv paths: [/tmp/tiup-data/tikv-20160 /tmp/tiup-log/tikv-20160 /tmp/tiup-deploy/tikv-20160 /etc/systemd/system/tikv-20160.service]
Destroying component resource-manager
        Destroying instance 10.2.12.124
Destroy 10.2.12.124 finished
- Destroy resource-manager paths: [/tmp/tiup-log/resource-manager-3377 /tmp/tiup-deploy/resource-manager-3377 /etc/systemd/system/resource-manager-3377.service /tmp/tiup-data/resource-manager-3377]
Destroying component scheduling
        Destroying instance 10.2.12.124
Destroy 10.2.12.124 finished
- Destroy scheduling paths: [/tmp/tiup-deploy/scheduling-3378 /etc/systemd/system/scheduling-3378.service /tmp/tiup-data/scheduling-3378 /tmp/tiup-log/scheduling-3378]
Destroying component tso
        Destroying instance 10.2.12.124
Destroy 10.2.12.124 finished
- Destroy tso paths: [/tmp/tiup-data/tso-3379 /tmp/tiup-log/tso-3379 /tmp/tiup-deploy/tso-3379 /etc/systemd/system/tso-3379.service]
Destroying component pd
        Destroying instance 10.2.12.124
Destroy 10.2.12.124 finished
- Destroy pd paths: [/tmp/tiup-data/pd-2379 /tmp/tiup-log/pd-2379 /tmp/tiup-deploy/pd-2379 /etc/systemd/system/pd-2379.service]
Destroying monitored 10.2.12.124
        Destroying instance 10.2.12.124
Destroy monitored on 10.2.12.124 success
Clean global directories 10.2.12.124
        Clean directory /tmp/tiup-log on instance 10.2.12.124
        Clean directory /tmp/tiup-deploy on instance 10.2.12.124
        Clean directory /tmp/tiup-data on instance 10.2.12.124
Clean global directories 10.2.12.124 success
Delete public key 10.2.12.124
Delete public key 10.2.12.124 success
Destroyed cluster `ms1` successfully
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@okJiang
implement rm cluster
b5c6164 
Signed-off-by: okjiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot requested a review from srstack December 26, 2025 02:36
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Dec 26, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 20.21661% with 221 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.87%. Comparing base (9338c69) to head (95443d9).

Files with missing lines Patch % Lines
pkg/cluster/spec/resource_manager.go 3.33% 144 Missing and 1 partial ⚠️
pkg/cluster/api/pdapi.go 0.00% 40 Missing ⚠️
pkg/cluster/task/update_meta.go 0.00% 11 Missing ⚠️
pkg/cluster/spec/validate.go 40.00% 5 Missing and 1 partial ⚠️
pkg/cluster/template/scripts/resource_manager.go 50.00% 3 Missing and 3 partials ⚠️
pkg/cluster/spec/monitoring.go 0.00% 5 Missing ⚠️
pkg/cluster/operation/upgrade.go 0.00% 3 Missing ⚠️
pkg/cluster/template/config/prometheus.go 0.00% 3 Missing ⚠️
components/cluster/command/upgrade.go 66.67% 1 Missing ⚠️
pkg/cluster/spec/spec.go 97.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2659      +/-   ##
==========================================
- Coverage   39.08%   38.87%   -0.21%     
==========================================
  Files         356      358       +2     
  Lines       37022    37256     +234     
==========================================
+ Hits        14468    14483      +15     
- Misses      20746    20960     +214     
- Partials     1808     1813       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@okJiang
Copy link
Member Author

okJiang commented Dec 26, 2025

/retest

1 similar comment
@okJiang
Copy link
Member Author

okJiang commented Dec 26, 2025

/retest

@okJiang
debug ci
682353e 
Signed-off-by: okjiang <819421878@qq.com>
@okJiang
add wait time
95443d9 
Signed-off-by: okjiang <819421878@qq.com>
@xhebox xhebox merged commit bdee7c1 into pingcap:master Jan 5, 2026
26 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srstack srstack Awaiting requested review from srstack

Assignees

No one assigned

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@okJiang @codecov-commenter @xhebox