refactor: UploadButton #801
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @juliusmarminge and the rest of your teammates on |
| ``` | ||
|
|
||
| <UploadButton | ||
| endpoint="mockRoute" |
There was a problem hiding this comment.
having these actually load instead of fetch failing helped reduce some impossible states we had weird paths for just to display in here
juliusmarminge
force-pushed
the
05-12-refactor_uploadbutton
branch
from
ae060af to
4e30034
Compare
|
|
||
| return "uploading"; | ||
| })(); | ||
| if (state === "readying") { |
There was a problem hiding this comment.
nit: inline return
| return `Choose File${inputProps.multiple ? `(s)` : ``}`; | ||
| } | ||
|
|
||
| if (uploadProgress === 100) { |
There was a problem hiding this comment.
nit: inline return
| > | ||
| {contentFieldToContent($props.content?.allowedContent, styleFieldArg) ?? | ||
| allowedContentTextLabelGenerator(permittedFileInfo?.config)} | ||
| allowedContentTextLabelGenerator(routeConfig)} |
There was a problem hiding this comment.
this is so much cleaner than permittedFileInfo 😅
Merge activity
|
More changes brought over from #746 but in a non-breaking, less chaotic manner.
Goal to make #802 easier