-
-
Notifications
You must be signed in to change notification settings - Fork 24
snowcap: add TextInput widget #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
snowcap: add TextInput widget #369
Conversation
33b380b to
756d3af
Compare
@Ottatop do you have thought on that ? Most The second point is only for types without a default implementation. The alternative is to hardcode our own default when the translation between protobuf & iced types fails. |
Agree, it would be best to crack down on these panics (especially if anyone wants to make protobuf bindings), though I strongly recommend doing this in another PR seeing as this one's already up to 2.5k lines |
Agree, I'll only try to remove the ones introduced by this PR and removable :) |
7998627 to
d4aa251
Compare
|
Allright, I think that's all. FYI, the PR is on top of #364. because I needed some of the changes from that PR, and it makes for a cleaner history that cherry-picking the commits I need (plus the eventual rebase hell if I discovered some issue in that PR). It should rebase cleanly should you choose to first pull the other one, and then rebase + merge this one (which could also be easier to review, I guess ?) OTOH, you can also close the other one and track everything here if you prefer. |
6944918 to
f4196da
Compare
9c32f92 to
153ca98
Compare
3ef8c4e to
8d33651
Compare
6061502 to
1bc0e09
Compare
3d1a835 to
93bad12
Compare
a59ef88 to
6acffe8
Compare
6acffe8 to
5b10445
Compare
5b10445 to
efae1e1
Compare
The more I think about this, the less viable it seems without either missing out on some iced functionality or essentially "flattening out" messages. Plus we'd still have to maintain previous messages for a time. The alternative solution is to follow iced and make additive changes to support any breaking iced updates (like a I'd like to move forward with adding the background message here and deprecating any |
Okay ! Just to clarify, you want another PR to add both the background and the depreciation, right ? I keep this one as-is, but I cherry-pick back the old commit in a new MR). That way this MR can move along, and depending on which is merged first, the new one will have to remove the background color from text-input, or I'll remove the background_color from this one |
efae1e1 to
2932972
Compare
Yep. I'm probably going to merge it first before reviewing this PR. |
The title say it all.
This PR adds TextInput widget, which will be useful as a building block for e.g. prompts.
On top of that, I've enabled support for key-repetition so the prompt themselves feel more natural.
TODO:
Postponed to [API] Gracefully handle protobuf translation issues #370Removed the ones from this PR.