S3Writer improvements #508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Buffer File Management
Enhanced Error Handling
Simplified Architecture
Also simplified S3Writer.close() to only:
Cancel scheduled upload tasks
This fixes a shutdown race condition with
DefautlLogMonitorin which it would incorrectly report the log streams as "stuck" due to the blocking nature ofS3Writer.close(). Now shutdown should be faster and consistent with other writers. Data should be safety maintained since buffer files are preserved on disk and Singer can resume uploads after restart. In addition, we can prevent spikes in uploads to S3 during daily Singer restarts.The only drawback to this is that the chance for data loss when the instance shuts down will be higher depending on the upload interval configured by the user and the grace period for shutdown. However, this is okay as we can't 100% guarantee no data loss during shutdowns or host failures in the first place. In addition, this follows the same principles as other OSS agents like FluentBit