Add configurable pod log directory cleanup behavior #517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem (Why)
The current pod log directory cleanup behavior is relies on creating dot files for external cleanup processes. This PR introduces a new configuration option to enable direct automatic cleanup of pod log directories when pods are deleted.
Solution (What + How)
enablePodLogDirectoryCleanupto the KubeConfig Thrift struct and corresponding config parsing.LogStreamManagerto conditionally delete pod log directories directly if the new config is enabled, otherwise fallback to creating a tombstone file.Test Plan
testPodDirectoryDeletionunit test to verify pod directory is deleted directly and no dot file is created when the new config is enabled.