Skip to content

Improve exception handling of MissingDirChecker #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jfzunigac merged 1 commit into from
Dec 11, 2025
Merged

Improve exception handling of MissingDirChecker #521

jfzunigac merged 1 commit into from
Dec 11, 2025
+39 −19

Conversation

@jfzunigac
Copy link
Contributor

@jfzunigac jfzunigac commented Dec 11, 2025

  1. Catch any exception and continue to retry so we don't exit out of the thread loop when we have dynamic directory log streams
  2. Emit metric when sorting of log streams fail

@jfzunigac jfzunigac requested a review from a team as a code owner December 11, 2025 18:38
@jfzunigac jfzunigac merged commit dd92d35 into pinterest:master Dec 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vahidhashemian vahidhashemian vahidhashemian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jfzunigac @vahidhashemian