Development #32

pladisdev · 2025-11-25T21:25:43Z

No description provided.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

…4b50-93c4-0e11b13594f4 Clarify error handler ordering is correct - no changes needed

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

…47b6-b204-5bf8892748d3 Extract magic numbers to named constants in audio playback code

…4606-8149-97ceaa22873d Use platform.system() instead of sys.platform for OS detection

Extract duplicated hex opacity calculation to utility function

Extract avatar active offset magic number into configurable setting

Fix audio reference cleanup on play() failure in popup mode

Fix race condition in popup avatar lifecycle

Copilot

Pull request overview

This PR includes a patch release (v1.3.1) that addresses several technical improvements: refactoring queue management imports to use a dedicated module, fixing a frontend undefined check bug, enhancing settings loading with default value merging for backward compatibility, and improving test isolation with credential mocking.

Key Changes

Refactored queue object imports (avatar_message_queue, parallel_message_queue) from app to modules.queue_manager across multiple router files for better code organization
Fixed frontend undefined check to prevent incorrect custom mode activation when parallelMessageLimit is undefined
Enhanced get_settings() to merge database settings with defaults for backward compatibility with older databases

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
frontend/src/components/settings/GeneralSettings.jsx	Added undefined check to prevent incorrect custom mode when parallelMessageLimit is not loaded
backend/version.py	Bumped version from 1.3.0 to 1.3.1 for patch release
backend/tests/test_clearchat.py	Added fixture to mock Twitch credentials at module level
backend/routers/system.py	Refactored to import parallel_message_queue from modules.queue_manager
backend/routers/config_backup.py	Refactored to import avatar_message_queue from modules.queue_manager
backend/routers/avatars.py	Refactored to import avatar_message_queue from modules.queue_manager across multiple endpoints
backend/modules/persistent_data.py	Enhanced get_settings() to merge defaults with database settings for backward compatibility

Comments suppressed due to low confidence (1)

backend/tests/test_clearchat.py:7

Import of 'os' is not used.

import os

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot · 2025-11-25T21:29:29Z

backend/tests/test_clearchat.py

 """
 import pytest
 import asyncio
+import os


The os import is unused and should be removed.

Suggested change

import os

Copilot · 2025-11-25T21:29:30Z

backend/tests/test_clearchat.py

+@pytest.fixture(autouse=True)
+def mock_twitch_credentials(monkeypatch):
+    """Mock Twitch credentials for all tests - module level to ensure it's set before imports"""
+    # Patch the module-level constants that were already imported
+    import modules.persistent_data
+    monkeypatch.setattr(modules.persistent_data, 'TWITCH_CLIENT_ID', 'test_client_id')
+    monkeypatch.setattr(modules.persistent_data, 'TWITCH_CLIENT_SECRET', 'test_client_secret')


This fixture has the same name as the autouse fixture in conftest.py (lines 45-67), which will be shadowed by this local fixture for this test module. Consider either:

Renaming this fixture to avoid confusion (e.g., mock_twitch_module_credentials)

Removing this fixture if the conftest.py one is sufficient

Adding a comment explaining why this duplicate/override is necessary

The conftest.py fixture sets environment variables, while this one patches module-level constants. If both are needed, the naming conflict should be resolved.

Copilot · 2025-11-25T21:29:30Z

backend/modules/persistent_data.py

+                return defaults
    except Exception as e:
        logger.error(f"Error loading settings: {e}")
        return {}


The exception handler returns an empty dict {} instead of defaults, which is inconsistent with the behavior when no settings are found in the database (line 109, which returns defaults). Consider returning defaults here as well to ensure the application has sensible default values even in error cases.

Suggested change

return {}

return defaults

github-actions · 2025-11-25T21:30:03Z

✅ Windows Build Successful

Executable: ChatYapper.exe (68.31 MB)
MSI Installer: ChatYapper-1.3.1.msi (67.65 MB)
App Version: 1.3.1
Build ID: build-v1.3.1-2025.11.25-10ca204
Commit: 10ca204

Build Status

✅ Windows executable & MSI installer
🔄 Linux build (check separate job)
🔄 Docker image (check separate job)

Download the artifacts from the workflow run to test before merging.

Once merged to main, an official release will be created automatically with tag v1.3.1.

github-actions · 2025-11-25T21:31:09Z

🐳 Docker Image Built Successfully

Image: ghcr.io/pladisdev/chat-yapper:pr-10ca204
Tag: pr-10ca204

Test this PR with Docker:

docker pull ghcr.io/pladisdev/chat-yapper:pr-10ca204

docker run -d \
  --name chat-yapper-pr \
  -p 8069:8008 \
  -e TWITCH_CLIENT_ID=your_id \
  -e TWITCH_CLIENT_SECRET=your_secret \
  ghcr.io/pladisdev/chat-yapper:pr-10ca204

Access at: http://localhost:8069

The Docker image will be published to the GitHub Container Registry when merged to main.

github-actions · 2025-11-25T21:34:54Z

✅ Windows Build Successful

Executable: ChatYapper.exe (68.31 MB)
MSI Installer: ChatYapper-1.3.1.msi (67.65 MB)
App Version: 1.3.1
Build ID: build-v1.3.1-2025.11.25-12339a4
Commit: 12339a4

Build Status

✅ Windows executable & MSI installer
🔄 Linux build (check separate job)
🔄 Docker image (check separate job)

Download the artifacts from the workflow run to test before merging.

Once merged to main, an official release will be created automatically with tag v1.3.1.

github-actions · 2025-11-25T21:35:45Z

🐳 Docker Image Built Successfully

Image: ghcr.io/pladisdev/chat-yapper:pr-12339a4
Tag: pr-12339a4

Test this PR with Docker:

docker pull ghcr.io/pladisdev/chat-yapper:pr-12339a4

docker run -d \
  --name chat-yapper-pr \
  -p 8069:8008 \
  -e TWITCH_CLIENT_ID=your_id \
  -e TWITCH_CLIENT_SECRET=your_secret \
  ghcr.io/pladisdev/chat-yapper:pr-12339a4

Access at: http://localhost:8069

The Docker image will be published to the GitHub Container Registry when merged to main.

pladisdev and others added 30 commits November 2, 2025 09:42

pop up mode and chat buble toggle

56e44f8

potential audio fix

82db2b0

linux sh and better docker support

579683d

fixed linux build?

fad6d1a

linux fix part 2

a12de82

docker fix part 1

5d79afe

Initial plan

0f3af89

Initial plan

d5d90f6

Initial plan

cbf5fcd

Initial plan

5a5d1d5

Initial plan

207ba9b

Initial plan

76b9912

Initial plan

366b640

Update frontend/src/pages/YappersPage.jsx

ebc7bb7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

be9a086

Update frontend/src/pages/YappersPage.jsx

3fc9146

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Replace sys.platform with platform.system() for OS detection

914b789

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix race condition in popup avatar lifecycle

938886f

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Extract magic numbers to named constants for better readability

7737a2f

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Extract magic number -2.5px into avatarActiveOffset setting

3ea0d45

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix audio cleanup in popup mode when play() fails

ee4de2a

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Merge pull request #17 from pladisdev/copilot/sub-pr-8-bf786502-ac5d-…

3ae0527

…4b50-93c4-0e11b13594f4 Clarify error handler ordering is correct - no changes needed

Extract hex opacity calculation to utility function

25dc303

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix audio error handlers to clean up tracking references

730dc88

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Merge pull request #16 from pladisdev/copilot/sub-pr-8-4be2dd0e-06ec-…

bb266bd

…47b6-b204-5bf8892748d3 Extract magic numbers to named constants in audio playback code

Merge pull request #15 from pladisdev/copilot/sub-pr-8-9e407134-0238-…

7d70a13

…4606-8149-97ceaa22873d Use platform.system() instead of sys.platform for OS detection

Merge pull request #14 from pladisdev/copilot/sub-pr-8-please-work

d1f450d

Extract duplicated hex opacity calculation to utility function

Merge pull request #13 from pladisdev/copilot/sub-pr-8-one-more-time

5436727

Extract avatar active offset magic number into configurable setting

Merge pull request #12 from pladisdev/copilot/sub-pr-8-yet-again

d8c850e

Fix audio reference cleanup on play() failure in popup mode

Merge pull request #11 from pladisdev/copilot/sub-pr-8-another-one

1405787

Fix race condition in popup avatar lifecycle

pladisdev and others added 19 commits November 22, 2025 19:57

update readme, version

c09bdcc

Merge branch 'main' into development

1cb53f6

emergency twitch fix

ee60426

Merge branch 'main' into development

56967e2

Merge branch 'main' into development

cfcf2dd

yep

1aa6813

dang

5844084

better twitch logging

4a6a8e5

animations and avatar layout editor

693bfbc

fix spin animation

326928e

twitch fix part 2

a80e583

Merge branch 'main' into development

69800d3

twitch fix, better fonts, cleanup

365ef8e

Merge branch 'main' into development

61d9dcf

fixed imports

046c52f

fixed things

7b33d13

Merge branch 'main' into development

638fb4e

undefined fix

59a7722

twitch test fix

4a09f0b

Copilot AI review requested due to automatic review settings November 25, 2025 21:25

another mock fix

99b9642

Copilot started reviewing on behalf of pladisdev November 25, 2025 21:26 View session

Copilot finished reviewing on behalf of pladisdev November 25, 2025 21:28

Copilot AI reviewed Nov 25, 2025

View reviewed changes

another fix for twitch creds tests

15efb3c

pladisdev merged commit d248765 into main Nov 25, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Development #32

Development #32

Uh oh!

pladisdev commented Nov 25, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Development #32

Development #32

Uh oh!

Conversation

pladisdev commented Nov 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 25, 2025

✅ Windows Build Successful

Build Status

Uh oh!

github-actions bot commented Nov 25, 2025

🐳 Docker Image Built Successfully

Test this PR with Docker:

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2025

✅ Windows Build Successful

Build Status

Uh oh!

github-actions bot commented Nov 25, 2025

🐳 Docker Image Built Successfully

Test this PR with Docker:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants