Development #34

pladisdev · 2025-11-25T22:15:08Z

No description provided.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

…4b50-93c4-0e11b13594f4 Clarify error handler ordering is correct - no changes needed

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

…47b6-b204-5bf8892748d3 Extract magic numbers to named constants in audio playback code

…4606-8149-97ceaa22873d Use platform.system() instead of sys.platform for OS detection

Extract duplicated hex opacity calculation to utility function

Extract avatar active offset magic number into configurable setting

Fix audio reference cleanup on play() failure in popup mode

Fix race condition in popup avatar lifecycle

Copilot

Pull request overview

This pull request is a development release (version 1.3.1) that includes bug fixes, error handling improvements, and refactoring to resolve circular import dependencies. The changes focus on improving Twitch bot lifecycle management, YouTube authentication error handling, and cleaning up the module structure.

Key changes:

Refactored queue imports from app module to modules.queue_manager to eliminate circular dependencies
Enhanced YouTube listener with specific RefreshError handling and improved error messages
Improved Twitch bot lifecycle with duplicate start prevention and cleaner shutdown handling
Merged settings defaults into database settings for backward compatibility with new settings

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
deployment/ChatYapper.wxs	Version bump to 1.3.1
backend/version.py	Version bump to 1.3.1
frontend/src/components/settings/GeneralSettings.jsx	Added undefined check for parallelMessageLimit
backend/tests/test_clearchat.py	Added credential check and skip decorator for TwitchBot tests
backend/routers/system.py	Refactored parallel_message_queue import to use queue_manager module
backend/routers/config_backup.py	Refactored avatar_message_queue import to use queue_manager module
backend/routers/avatars.py	Refactored queue imports to use queue_manager module; minor formatting fix
backend/modules/youtube_listener.py	Added RefreshError exception handling with clearer error messages
backend/modules/persistent_data.py	Enhanced get_settings() to merge database settings with defaults
backend/app.py	Improved Twitch bot lifecycle with duplicate prevention, custom exception handler, and additional logging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot · 2025-11-25T22:17:37Z

backend/app.py

+
            # Event router to handle different event types
            async def route_twitch_event(e):
+                logger.info(f"[EVENT ROUTER] Received event: type={e.get('type')}, user={e.get('user')}, text={e.get('text', '')[:50]}")


Debug logging statement appears to be left in production code. The "[EVENT ROUTER]" prefix and verbose logging suggest this was added for debugging. Consider removing this line or reducing its log level to logger.debug() if it's intended for troubleshooting purposes only.

Suggested change

logger.info(f"[EVENT ROUTER] Received event: type={e.get('type')}, user={e.get('user')}, text={e.get('text', '')[:50]}")

logger.debug(f"[EVENT ROUTER] Received event: type={e.get('type')}, user={e.get('user')}, text={e.get('text', '')[:50]}")

Copilot · 2025-11-25T22:17:37Z

backend/app.py

+
+                # Event router to handle different event types
+                async def route_twitch_event(e):
+                    logger.info(f"[EVENT ROUTER] Received event: type={e.get('type')}, user={e.get('user')}, text={e.get('text', '')[:50]}")


Duplicate debug logging statement. This appears to be the same debug log as line 521 in the restart function. Consider removing this line or reducing its log level to logger.debug() if it's intended for troubleshooting purposes only.

Suggested change

logger.info(f"[EVENT ROUTER] Received event: type={e.get('type')}, user={e.get('user')}, text={e.get('text', '')[:50]}")

logger.debug(f"[EVENT ROUTER] Received event: type={e.get('type')}, user={e.get('user')}, text={e.get('text', '')[:50]}")

github-actions · 2025-11-25T22:19:50Z

✅ Windows Build Successful

Executable: ChatYapper.exe (68.31 MB)
MSI Installer: ChatYapper-1.3.1.msi (67.65 MB)
App Version: 1.3.1
Build ID: build-v1.3.1-2025.11.25-c19975a
Commit: c19975a

Build Status

✅ Windows executable & MSI installer
🔄 Linux build (check separate job)
🔄 Docker image (check separate job)

Download the artifacts from the workflow run to test before merging.

Once merged to main, an official release will be created automatically with tag v1.3.1.

github-actions · 2025-11-25T22:20:41Z

🐳 Docker Image Built Successfully

Image: ghcr.io/pladisdev/chat-yapper:pr-c19975a
Tag: pr-c19975a

Test this PR with Docker:

docker pull ghcr.io/pladisdev/chat-yapper:pr-c19975a

docker run -d \
  --name chat-yapper-pr \
  -p 8069:8008 \
  -e TWITCH_CLIENT_ID=your_id \
  -e TWITCH_CLIENT_SECRET=your_secret \
  ghcr.io/pladisdev/chat-yapper:pr-c19975a

Access at: http://localhost:8069

The Docker image will be published to the GitHub Container Registry when merged to main.

pladisdev and others added 30 commits November 2, 2025 09:42

pop up mode and chat buble toggle

56e44f8

potential audio fix

82db2b0

linux sh and better docker support

579683d

fixed linux build?

fad6d1a

linux fix part 2

a12de82

docker fix part 1

5d79afe

Initial plan

0f3af89

Initial plan

d5d90f6

Initial plan

cbf5fcd

Initial plan

5a5d1d5

Initial plan

207ba9b

Initial plan

76b9912

Initial plan

366b640

Update frontend/src/pages/YappersPage.jsx

ebc7bb7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

be9a086

Update frontend/src/pages/YappersPage.jsx

3fc9146

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Replace sys.platform with platform.system() for OS detection

914b789

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix race condition in popup avatar lifecycle

938886f

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Extract magic numbers to named constants for better readability

7737a2f

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Extract magic number -2.5px into avatarActiveOffset setting

3ea0d45

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix audio cleanup in popup mode when play() fails

ee4de2a

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Merge pull request #17 from pladisdev/copilot/sub-pr-8-bf786502-ac5d-…

3ae0527

…4b50-93c4-0e11b13594f4 Clarify error handler ordering is correct - no changes needed

Extract hex opacity calculation to utility function

25dc303

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix audio error handlers to clean up tracking references

730dc88

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Merge pull request #16 from pladisdev/copilot/sub-pr-8-4be2dd0e-06ec-…

bb266bd

…47b6-b204-5bf8892748d3 Extract magic numbers to named constants in audio playback code

Merge pull request #15 from pladisdev/copilot/sub-pr-8-9e407134-0238-…

7d70a13

…4606-8149-97ceaa22873d Use platform.system() instead of sys.platform for OS detection

Merge pull request #14 from pladisdev/copilot/sub-pr-8-please-work

d1f450d

Extract duplicated hex opacity calculation to utility function

Merge pull request #13 from pladisdev/copilot/sub-pr-8-one-more-time

5436727

Extract avatar active offset magic number into configurable setting

Merge pull request #12 from pladisdev/copilot/sub-pr-8-yet-again

d8c850e

Fix audio reference cleanup on play() failure in popup mode

Merge pull request #11 from pladisdev/copilot/sub-pr-8-another-one

1405787

Fix race condition in popup avatar lifecycle

pladisdev and others added 22 commits November 22, 2025 21:18

emergency twitch fix

ee60426

Merge branch 'main' into development

56967e2

Merge branch 'main' into development

cfcf2dd

yep

1aa6813

dang

5844084

better twitch logging

4a6a8e5

animations and avatar layout editor

693bfbc

fix spin animation

326928e

twitch fix part 2

a80e583

Merge branch 'main' into development

69800d3

twitch fix, better fonts, cleanup

365ef8e

Merge branch 'main' into development

61d9dcf

fixed imports

046c52f

fixed things

7b33d13

Merge branch 'main' into development

638fb4e

undefined fix

59a7722

twitch test fix

4a09f0b

another mock fix

99b9642

another fix for twitch creds tests

15efb3c

better logging

6ca3832

twitch fixes?

08355e7

another twitch fix

0d7bb86

Copilot AI review requested due to automatic review settings November 25, 2025 22:15

Copilot started reviewing on behalf of pladisdev November 25, 2025 22:15 View session

Merge branch 'main' into development

484caaf

pladisdev merged commit e44cc14 into main Nov 25, 2025
8 checks passed

Copilot finished reviewing on behalf of pladisdev November 25, 2025 22:17

Copilot AI reviewed Nov 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Development #34

Development #34

Uh oh!

pladisdev commented Nov 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	logger.info(f"[EVENT ROUTER] Received event: type={e.get('type')}, user={e.get('user')}, text={e.get('text', '')[:50]}")
	logger.debug(f"[EVENT ROUTER] Received event: type={e.get('type')}, user={e.get('user')}, text={e.get('text', '')[:50]}")

Development #34

Development #34

Uh oh!

Conversation

pladisdev commented Nov 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 25, 2025

✅ Windows Build Successful

Build Status

Uh oh!

github-actions bot commented Nov 25, 2025

🐳 Docker Image Built Successfully

Test this PR with Docker:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants