Development #36

pladisdev · 2025-11-25T22:38:19Z

No description provided.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

…4b50-93c4-0e11b13594f4 Clarify error handler ordering is correct - no changes needed

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

…47b6-b204-5bf8892748d3 Extract magic numbers to named constants in audio playback code

…4606-8149-97ceaa22873d Use platform.system() instead of sys.platform for OS detection

Extract duplicated hex opacity calculation to utility function

Extract avatar active offset magic number into configurable setting

Fix audio reference cleanup on play() failure in popup mode

Fix race condition in popup avatar lifecycle

…into development

Copilot

Pull request overview

This PR appears to be a development branch merge that includes two main changes: (1) modifying the Twitch bot's channel joining behavior to rely on TwitchIO's automatic channel joining instead of explicit join_channels() calls, and (2) standardizing CI/CD workflows to use Python 3.10 exclusively.

Key Changes:

Removed explicit join_channels() call in event_ready(), relying instead on TwitchIO 3.x's automatic joining behavior from initial_channels
Added debug logging to verify connected channels and available bot methods
Reduced Python version testing matrix from [3.9, 3.10, 3.11] to only [3.10] in test workflows
Downgraded build/release workflows from Python 3.11 to Python 3.10

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
backend/modules/twitch_listener.py	Modified `event_ready()` to remove explicit channel joining and add debug logging for connected channels and bot methods
.github/workflows/tests.yml	Reduced Python test matrix from multiple versions (3.9, 3.10, 3.11) to only Python 3.10
.github/workflows/build-and-release.yml	Downgraded Python version from 3.11 to 3.10 in both build and release jobs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot · 2025-11-25T22:41:15Z

backend/modules/twitch_listener.py

+                logger.info(f"Connected channels: {list(self.connected_channels)}")
+
+            # Log available methods for debugging
+            logger.debug(f"Bot methods: {[m for m in dir(self) if 'channel' in m.lower() or 'join' in m.lower()]}")


This debug logging statement appears to be temporary debugging code and should be removed before merging. Logging all methods with 'channel' or 'join' in their names could expose unnecessary internal implementation details and adds no value in production. Consider removing this line or moving it to a more targeted test/debugging context.

Suggested change

logger.debug(f"Bot methods: {[m for m in dir(self) if 'channel' in m.lower() or 'join' in m.lower()]}")

Copilot · 2025-11-25T22:41:16Z

.github/workflows/tests.yml

    strategy:
      matrix:
-        python-version: ['3.9', '3.10', '3.11']
+        python-version: ['3.10']


Removing Python 3.9 and 3.11 from the test matrix reduces test coverage across supported Python versions. The README.md states the project requires "Python 3.9+" (line 130), but this change only tests Python 3.10. Consider either:

Keeping the original matrix to test across all supported versions (3.9, 3.10, 3.11), or

Updating the README.md to reflect the actual supported Python version if only 3.10 is supported.

This ensures consistency between documentation and CI testing.

Copilot · 2025-11-25T22:41:16Z

.github/workflows/build-and-release.yml

+    - name: Set up Python 3.10
      uses: actions/setup-python@v4
      with:
-        python-version: '3.11'
+        python-version: '3.10'


This change downgrades the Python version from 3.11 to 3.10, which is inconsistent with the project's stated requirements. The README.md specifies "Python 3.9+" (line 130). If Python 3.10 is specifically required for the build process, the documentation should be updated to clarify this. Otherwise, consider using Python 3.11 to align with the latest stable version and ensure forward compatibility.

Copilot · 2025-11-25T22:41:16Z

.github/workflows/build-and-release.yml

+    - name: Set up Python 3.10
      uses: actions/setup-python@v4
      with:
-        python-version: '3.11'
+        python-version: '3.10'


This change downgrades the Python version from 3.11 to 3.10, which is inconsistent with the project's stated requirements. The README.md specifies "Python 3.9+" (line 130). If Python 3.10 is specifically required for the build process, the documentation should be updated to clarify this. Otherwise, consider using Python 3.11 to align with the latest stable version and ensure forward compatibility.

Copilot · 2025-11-25T22:41:16Z

backend/modules/twitch_listener.py

+            # In TwitchIO 3.x, channels from initial_channels should auto-join
+            # But we can verify by checking connected channels
+            if hasattr(self, 'connected_channels'):
+                logger.info(f"Connected channels: {list(self.connected_channels)}")
+
+            # Log available methods for debugging
+            logger.debug(f"Bot methods: {[m for m in dir(self) if 'channel' in m.lower() or 'join' in m.lower()]}")
+


The modified event_ready method now relies on TwitchIO's automatic channel joining behavior instead of explicitly calling join_channels(). This behavioral change lacks test coverage. Consider adding a test to verify that:

Channels specified in initial_channels are automatically joined

The connected_channels attribute is properly populated after the bot is ready

The bot can successfully receive messages from the auto-joined channel

This is especially important given the comment mentions this is a TwitchIO 3.x-specific behavior that should be verified.

github-actions · 2025-11-25T22:42:39Z

✅ Windows Build Successful

Executable: ChatYapper.exe (62.64 MB)
MSI Installer: ChatYapper-1.3.1.msi (61.98 MB)
App Version: 1.3.1
Build ID: build-v1.3.1-2025.11.25-8844929
Commit: 8844929

Build Status

✅ Windows executable & MSI installer
🔄 Linux build (check separate job)
🔄 Docker image (check separate job)

Download the artifacts from the workflow run to test before merging.

Once merged to main, an official release will be created automatically with tag v1.3.1.

github-actions · 2025-11-25T22:43:36Z

🐳 Docker Image Built Successfully

Image: ghcr.io/pladisdev/chat-yapper:pr-8844929
Tag: pr-8844929

Test this PR with Docker:

docker pull ghcr.io/pladisdev/chat-yapper:pr-8844929

docker run -d \
  --name chat-yapper-pr \
  -p 8069:8008 \
  -e TWITCH_CLIENT_ID=your_id \
  -e TWITCH_CLIENT_SECRET=your_secret \
  ghcr.io/pladisdev/chat-yapper:pr-8844929

Access at: http://localhost:8069

The Docker image will be published to the GitHub Container Registry when merged to main.

pladisdev and others added 30 commits November 2, 2025 09:42

pop up mode and chat buble toggle

56e44f8

potential audio fix

82db2b0

linux sh and better docker support

579683d

fixed linux build?

fad6d1a

linux fix part 2

a12de82

docker fix part 1

5d79afe

Initial plan

0f3af89

Initial plan

d5d90f6

Initial plan

cbf5fcd

Initial plan

5a5d1d5

Initial plan

207ba9b

Initial plan

76b9912

Initial plan

366b640

Update frontend/src/pages/YappersPage.jsx

ebc7bb7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

be9a086

Update frontend/src/pages/YappersPage.jsx

3fc9146

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Replace sys.platform with platform.system() for OS detection

914b789

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix race condition in popup avatar lifecycle

938886f

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Extract magic numbers to named constants for better readability

7737a2f

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Extract magic number -2.5px into avatarActiveOffset setting

3ea0d45

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix audio cleanup in popup mode when play() fails

ee4de2a

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Merge pull request #17 from pladisdev/copilot/sub-pr-8-bf786502-ac5d-…

3ae0527

…4b50-93c4-0e11b13594f4 Clarify error handler ordering is correct - no changes needed

Extract hex opacity calculation to utility function

25dc303

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Fix audio error handlers to clean up tracking references

730dc88

Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>

Merge pull request #16 from pladisdev/copilot/sub-pr-8-4be2dd0e-06ec-…

bb266bd

…47b6-b204-5bf8892748d3 Extract magic numbers to named constants in audio playback code

Merge pull request #15 from pladisdev/copilot/sub-pr-8-9e407134-0238-…

7d70a13

…4606-8149-97ceaa22873d Use platform.system() instead of sys.platform for OS detection

Merge pull request #14 from pladisdev/copilot/sub-pr-8-please-work

d1f450d

Extract duplicated hex opacity calculation to utility function

Merge pull request #13 from pladisdev/copilot/sub-pr-8-one-more-time

5436727

Extract avatar active offset magic number into configurable setting

Merge pull request #12 from pladisdev/copilot/sub-pr-8-yet-again

d8c850e

Fix audio reference cleanup on play() failure in popup mode

Merge pull request #11 from pladisdev/copilot/sub-pr-8-another-one

1405787

Fix race condition in popup avatar lifecycle

pladisdev and others added 21 commits November 22, 2025 22:52

dang

5844084

better twitch logging

4a6a8e5

animations and avatar layout editor

693bfbc

fix spin animation

326928e

twitch fix part 2

a80e583

Merge branch 'main' into development

69800d3

twitch fix, better fonts, cleanup

365ef8e

Merge branch 'main' into development

61d9dcf

fixed imports

046c52f

fixed things

7b33d13

Merge branch 'main' into development

638fb4e

undefined fix

59a7722

twitch test fix

4a09f0b

another mock fix

99b9642

another fix for twitch creds tests

15efb3c

better logging

6ca3832

twitch fixes?

08355e7

another twitch fix

0d7bb86

Merge branch 'main' into development

484caaf

fix twitch io 3.x

a45dcfc

Merge branch 'development' of https://github.com/pladisdev/chat-yapper …

478e8ea

…into development

Copilot AI review requested due to automatic review settings November 25, 2025 22:38

pladisdev and others added 2 commits November 25, 2025 23:38

fix pipelines for python to use 3.10

6ad992d

Merge branch 'main' into development

2fcaa47

Copilot started reviewing on behalf of pladisdev November 25, 2025 22:38 View session

pladisdev merged commit cf75472 into main Nov 25, 2025
6 checks passed

Copilot finished reviewing on behalf of pladisdev November 25, 2025 22:40

Copilot AI reviewed Nov 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Development #36

Development #36

Uh oh!

pladisdev commented Nov 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Development #36

Development #36

Uh oh!

Conversation

pladisdev commented Nov 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 25, 2025

✅ Windows Build Successful

Build Status

Uh oh!

github-actions bot commented Nov 25, 2025

🐳 Docker Image Built Successfully

Test this PR with Docker:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants