Skip to content
This repository was archived by the owner on Aug 6, 2020. It is now read-only.

Conversation

@pjfanning
Copy link

@pjfanning pjfanning commented Jan 18, 2019

This is not working but I thought I'd post the existing state for review.
The scala-collection-compat dependency could be removed by copying some of its code into play-iteratees.

scala 2.12 compile fails

[error] /home/travis/build/pjfanning/play-iteratees/iteratees/src/main/scala/play/api/libs/iteratee/Iteratee.scala:586: Cannot construct a collection of type That with elements of type X based on a collection of type E.
[error]             case (Input.El(e1), Input.El(e2)) => Input.El[E](p(e1) ++ p(e2))
[error]                                                                    ^

scala 2.13 compile fails

[error] /home/travis/build/pjfanning/play-iteratees/iteratees/src/main/scala/play/api/libs/iteratee/CharEncoding.scala:45: type mismatch;
[error]  found   : play.api.libs.iteratee.Input[From]
[error]  required: play.api.libs.iteratee.Input[To]
[error]         val newIt = Iteratee.flatten(it.feed(in))
[error]                                              ^
[error] /home/travis/build/pjfanning/play-iteratees/iteratees/src/main/scala/play/api/libs/iteratee/CharEncoding.scala:52: type mismatch;
[error]  found   : play.api.libs.iteratee.Input[From]
[error]  required: play.api.libs.iteratee.Input[To]
[error]             val newIt = Iteratee.flatten(it.feed(Input.El(string)).flatMap(_.feed(in))(defaultExecutionContext))
[error]                                                                                   ^
[error] /home/travis/build/pjfanning/play-iteratees/iteratees/src/main/scala/play/api/libs/iteratee/Iteratee.scala:124: not enough arguments for method apply: (from: E)scala.collection.mutable.Builder[B,That] in trait BuildFrom.
[error] Unspecified value parameter from.
[error]         val builder = bf()
[error]                         ^
[error] /home/travis/build/pjfanning/play-iteratees/iteratees/src/main/scala/play/api/libs/iteratee/Iteratee.scala:586: type mismatch;
[error]  found   : Iterable[X]
[error]  required: E
[error]             case (Input.El(e1), Input.El(e2)) => Input.El[E](p(e1) ++ p(e2))
[error]                                                                    ^
[error] four errors found

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants