This repository was archived by the owner on Aug 6, 2020. It is now read-only.
update use of Futures to suit scala 2.13 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.sbt # project/build.properties # project/plugins.sbt
cchantep
approved these changes
Jul 15, 2019
|
@cchantep Any chance we'll see a 2.13 version soon? Not sure if there's anything I can do to help it along. |
cchantep
reviewed
Jan 14, 2020
| }(ec) | ||
| toReturn.onFailure { | ||
| case e => doneIteratee.failure(e) | ||
| toReturn.onComplete { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Partial fix for #16
Purpose
What does this PR do?
Removes the use of Future#onFailure due to scala 2.13 issues
Background Context
Why did you take this approach?
I've looked at the scala collections changes needed but there is still a lot of changes needed there. I thought I'd post the less awkward Future changes first.
References
Are there any relevant issues / PRs / mailing lists discussions?
#16
I messed up #19 trying to rebase it