[#2078] switchable python on windows #1093
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JSON response - added missing import
…a specific test category (unit, functional, selenium)
[playframework#1344] Fixed OAuth2 lib not finding access_token inside JSON response
…to define a custom path
[#1924] Sane c3p0 logging
[#1916] Get Java version from application.conf
…rMaster [#1937] fix(router): make some improvement in router
….1.35 Conflicts: framework/dependencies.yml
…ange of htmlUnit * [playframework#986] chore(lib): update htmlunit from 2.19 to 2.23
…e as a key message * [playframework#996] fix(messages): ensure default is null before using it # Conflicts: # framework/src/play/mvc/Scope.java
# Conflicts: # documentation/manual/home.textile
…gument
e.g. #{form '/customer/12' ....
…ately from controller execution time.
…when compiling a temaplate with a non GroovyInlineTag ** revert modif on GroovyTemplateCompiler.java don in 765dec2
so we can run all unit-tests in IDE by one click
it seems that it was broken. That's why http://localhost:9000/@db didn't show tables on the left
…patch [#2066] fix-open-file-on-500-error-pages-for-modules
…ed configLastModified on application start
…static args in routes # Conflicts: # framework/src/play/mvc/Router.java
…atch [#2066] avoid NPE in regex matcher
Detect changed for JNDI datasource which using jndi: prefix and its documentation
…uilding-modules-with-a-space-in-path-under-windows-fails [#1919] fixes Building modules with a space in path under windows fails
xael-fry
requested changes
Aug 14, 2017
Member
xael-fry
left a comment
xael-fry
left a comment
There was a problem hiding this comment.
Could you rebase it to ave only one commit?
Contributor
|
@xael-fry, IMHO, these changes are no longer needed since Python is no longer part of the framework. PR may be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
give some hints for usage on windows systems.
see at https://play.lighthouseapp.com/projects/57987-play-framework/tickets/2078