Skip to content

Conversation

@arielelkin
Copy link
Collaborator

@arielelkin arielelkin commented Oct 26, 2025

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Package.swift Outdated
Comment on lines 43 to 46
platforms: supportedPlatforms,
products: packageProducts,
targets: packageTargets,
swiftLanguageModes: [.v5],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Bump tools version before using Swift 6 manifest APIs

The swiftLanguageModes parameter is only available in the SwiftPM 6.0 manifest API, but this file still declares // swift-tools-version:5.9. When the package is parsed by a Swift 6 toolchain, the #if swift(>=6.0) block is compiled while PackageDescription remains at the 5.9 interface, so the initializer does not accept swiftLanguageModes and manifest parsing fails instead of merely warning. Either raise the tools version to 6.0 or keep using swiftLanguageVersions to avoid a build break on Swift 6.

Useful? React with 👍 / 👎.

@arielelkin arielelkin merged commit ffde582 into master Oct 26, 2025
3 checks passed
@arielelkin arielelkin deleted the codex/fix-deprecation-warning-in-package.swift branch October 26, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants