-
Notifications
You must be signed in to change notification settings - Fork 78
Faturrachman dev #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faturrachman dev #235
Conversation
task 1: launch configuration completes
|
I'm not completely against usage of AI in development. But AI should be the last step for double check everything in my opinion. So I'm personally against the using complete agent like cursor as you used. Since its up to @polymorphicshade to review and accept/reject I'm just curious about if PR can pass CI 🤠 |
| org.gradle.jvmargs=-Xmx2048M --add-opens jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED | ||
| org.gradle.jvmargs=-Xmx2048M --add-opens jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED -Dfile.encoding=utf8 | ||
| systemProp.file.encoding=utf-8 | ||
| org.gradle.java.home=F:\\Program Files (x86)\\jdk-17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fails CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah localized folder problem, pretty general problem.
Do you have any idea on how to make it flexible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI works without this line added. Also I do not need this property in my setup. So it would be better de just delete this line. If you need this prop for local development then just don't add it to commit list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, so if we do not add it, then it will use the default location right. Where is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk really
you can just remove this line to proceed to CI
Just by you dont hesitate to review and give comment gives me respect, i really appreciate it And you're right, i haven't really double checked the changes i've made by running it. Well its my first pr right :) But really, i do appreciate it, thanks my guy |
|
Remove all the AI stuff please 👍 |
integrates memory-bank for development..
( this is my first time pull-requiesting a public repo :D, so im fine with any choices )