Skip to content

Conversation

@Faturrachman-dev
Copy link

integrates memory-bank for development..

( this is my first time pull-requiesting a public repo :D, so im fine with any choices )

@asandikci
Copy link
Collaborator

asandikci commented Jun 6, 2025

I'm not completely against usage of AI in development. But AI should be the last step for double check everything in my opinion. So I'm personally against the using complete agent like cursor as you used. Since its up to @polymorphicshade to review and accept/reject I'm just curious about if PR can pass CI 🤠
edit: failed as expected

org.gradle.jvmargs=-Xmx2048M --add-opens jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED
org.gradle.jvmargs=-Xmx2048M --add-opens jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED -Dfile.encoding=utf8
systemProp.file.encoding=utf-8
org.gradle.java.home=F:\\Program Files (x86)\\jdk-17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fails CI

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah localized folder problem, pretty general problem.
Do you have any idea on how to make it flexible?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI works without this line added. Also I do not need this property in my setup. So it would be better de just delete this line. If you need this prop for local development then just don't add it to commit list

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, so if we do not add it, then it will use the default location right. Where is it?

Copy link
Collaborator

@asandikci asandikci Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk really
you can just remove this line to proceed to CI

@Faturrachman-dev
Copy link
Author

I'm not completely against usage of AI in development. But AI should be the last step for double check everything in my opinion. So I'm personally against the using complete agent like cursor as you used. Since its up to @polymorphicshade to review and accept/reject I'm just curious about if PR can pass CI 🤠
edit: failed as expected

Just by you dont hesitate to review and give comment gives me respect, i really appreciate it

And you're right, i haven't really double checked the changes i've made by running it. Well its my first pr right :)

But really, i do appreciate it, thanks my guy

@polymorphicshade
Copy link
Owner

Remove all the AI stuff please 👍

@asandikci asandikci closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants