Allow to choose max playback speed in settings to your liking #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
|
I like this idea! The only thing I would change about this is making the speeds powers of two (2, 4, 8, 16), so going to the next one doubles your max playback rate. My gut tells me that time stretching algorithms will sound better at powers of two. I could be wrong about that, but it would make sense given that a lot of things in sound tend to change in powers of two. Maybe allowing the user to input a number ≥ 2 to this would be best. Unlike the step size in the speed menu, it's not that disruptive to have the keyboard pop up to edit this value because it's in the settings menu rather than the player. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I personally would never want to go above 3x, others ask for up to 10x.
Having 10x does seem to fit everyone at first, but it gets quite frustrating, if you use my swipe to change speed feature and can only use 30% of it's range.
With this setting now, everyone can choose their desired upper limit (from options 2x, 3x, 5x and 10x) in settings and the speed dialog will obey as well as the swiping action.