Skip to content

Highlight cliked segment buttons #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NWuensche wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Highlight cliked segment buttons #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
346d4be
Works
NWuensche Aug 5, 2025
0358d25
fix color
NWuensche Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions ...n/java/org/schabi/newpipe/fragments/list/sponsorblock/SponsorBlockSegmentListAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,33 @@ private void updateFrom(final SponsorBlockSegment sponsorBlockSegment) {
final String endText = millisecondsToString(sponsorBlockSegment.endTime);
itemSegmentEndTimeTextView.setText(endText);

// Update vote button states
if (sponsorBlockSegment.category == SponsorBlockCategory.PENDING
|| sponsorBlockSegment.uuid.equals("TEMP")
|| sponsorBlockSegment.uuid.equals("")) {
itemSegmentVoteUpImageView.setVisibility(View.INVISIBLE);
itemSegmentVoteDownImageView.setVisibility(View.INVISIBLE);
} else {
itemSegmentVoteUpImageView.setVisibility(View.VISIBLE);
itemSegmentVoteDownImageView.setVisibility(View.VISIBLE);

// Update button states based on current vote
final int selectedColor =
context.getColor(R.color.sponsor_block_vote_button_selected);
final int defaultColor =
context.getColor(android.R.color.darker_gray);

if (hasUpVoted) {
itemSegmentVoteUpImageView.setColorFilter(selectedColor);
itemSegmentVoteDownImageView.setColorFilter(defaultColor);
} else if (hasDownVoted) {
itemSegmentVoteUpImageView.setColorFilter(defaultColor);
itemSegmentVoteDownImageView.setColorFilter(selectedColor);
} else {
// Reset to default colors when no vote
itemSegmentVoteUpImageView.setColorFilter(defaultColor);
itemSegmentVoteDownImageView.setColorFilter(defaultColor);
}
}
}

Expand Down Expand Up @@ -281,6 +303,11 @@ private void vote(final int value) {
Toast.makeText(context,
toastMessage,
Toast.LENGTH_SHORT).show();

// Update button states after voting
if (currentSponsorBlockSegment != null) {
updateFrom(currentSponsorBlockSegment);
}
}, throwable -> {
if (throwable instanceof NullPointerException) {
return;
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/res/values/colors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,5 +95,8 @@
<color name="preview_segment">#008fd6</color>
<color name="filler_segment">#7300ff</color>
<color name="pending_segment">#ffffff</color>

<!-- Vote button colors -->
<color name="sponsor_block_vote_button_selected">#CD201F</color>

</resources>