Use connection_pool as a dumb thread pool instead of Celluloid #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of depending on Celluloid, this would _always_ make the workers threaded (set DISC_CONCURRENCY=1 if you want a single thread...) Having a single code path is good, though. It means it's simpler to test features / bugfixes as we don't need to run every test by duplicte on threaded/nonthreaded mode. Oh, and speaking about tests, did I mention this is just a WIP? :P
Collaborator
Author
There was a problem hiding this comment.
Not entirely sure why Disc.disque_timeout had a default different from DISQUE_TIMEOUT. Was this on purpose?
Owner
|
I think dropping Celluloid and having a single code path are good things, however I'd like to move to something that won't break the non-threaded mode at least, what are your thoughts on the stability and safety of using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of depending on Celluloid, which is complex and way too much for what we actually nead, this sets up a ConnectionPool that checks out nothing (i.e. the connections are just
true), so that we can abuse it as a thread pool.This would always make the workers threaded (set
DISC_CONCURRENCY=1if you want a single thread...).Having a single code path is good, though. It means it's simpler to test features / bugfixes as we don't need to run every test by duplicate on threaded/nonthreaded mode.
Oh, and speaking about tests, did I mention this is just a WIP? :P
cc @pote