Adding build script for Tesserocr python package #7513
Conversation
|
4 Test cases are falling currently, do need all test case to pass before merge? |
|
@shubham-dayma-ibm and @nikhil-kalbande may you please assist with @adarshagrawal38 's request. Thank you. |
shubham-dayma-ibm
left a comment
shubham-dayma-ibm
left a comment
There was a problem hiding this comment.
The tests can only be skipped if it has genuine justification.
| # Source repo : https://github.com/sirfz/tesserocr | ||
| # Tested on : UBI 9.6 | ||
| # Language : Python | ||
| # Travis-Check : false |
There was a problem hiding this comment.
Replace Travis-Check : false to Ci-Check : True So PR checks can run and validate the script. tests should ideally pass. if not the script is missing something.
| fi | ||
|
|
||
| # Run nox if noxfile.py is present and previous tests failed | ||
| if [ -f "noxfile.py" ] && [ $test_status -ne 0 ]; then |
There was a problem hiding this comment.
nox block is not required.
There was a problem hiding this comment.
okay, I have removed it.
| test_status=1 # 0 = success, non-zero = failure | ||
|
|
||
| # Run pytest if any matching test files found | ||
| if ls */test_*.py > /dev/null 2>&1 && [ $test_status -ne 0 ]; then |
There was a problem hiding this comment.
is community supporting pytest? If not remove it
There was a problem hiding this comment.
community support is there
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
adarshagrawal38
force-pushed
the
tesserocr
branch
from
dbe574c to
a4ab76a
Compare
| echo "$PACKAGE_URL $PACKAGE_NAME" | ||
| echo "$PACKAGE_NAME | $PACKAGE_URL | $PACKAGE_VERSION | $OS_NAME | $SOURCE | Fail | Install_Failed" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Why aren't we executing the test cases?
There was a problem hiding this comment.
added block to run test cases using pytest (Community support is there for pytest)
PTAL
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
okay, All test cases are passing now. |
3 participants
Checklist
set -eoption enabled and observe success ?