Skip to content

Fix s3 temporary creds need session token #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kdesjard wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix s3 temporary creds need session token #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de1110f
S3: Temporary credentials need a session token
Kris-Desjardins Mar 6, 2023
fddfcf6
add s3 tests with session token
Kris-Desjardins Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/Signer/AWSv4/S3.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ package Signer::AWSv4::S3;
'X-Amz-Credential' => $self->access_key . "/" . $self->credential_scope,
'X-Amz-Date' => $self->date_timestamp,
'X-Amz-Expires' => $self->expires,
($self->session_token ? ('X-Amz-Security-Token' => $self->session_token) : () ),
'X-Amz-SignedHeaders' => $self->signed_header_list,
('response-content-disposition' => $self->content_disposition) x!! $self->content_disposition,
('response-content-type' => $self->content_type) x!! $self->content_type,
Expand Down
78 changes: 78 additions & 0 deletions t/02_s3_with_session_token.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
#!/usr/bin/env perl

use strict;
use warnings;

use Test::More;
use Signer::AWSv4::S3;

my $signer = Signer::AWSv4::S3->new(
time => Time::Piece->strptime('20130524T000000Z', '%Y%m%dT%H%M%SZ'),
access_key => 'AKIAIOSFODNN7EXAMPLE',
secret_key => 'wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY',
session_token => 'fooSessionToken9876543210',
method => 'GET',
key => 'test.txt',
bucket => 'examplebucket',
region => 'us-east-1',
expires => 86400,
);

my $expected_canon_request = 'GET
/examplebucket/test.txt
X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIOSFODNN7EXAMPLE%2F20130524%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20130524T000000Z&X-Amz-Expires=86400&X-Amz-Security-Token=fooSessionToken9876543210&X-Amz-SignedHeaders=host
host:s3.amazonaws.com

host
UNSIGNED-PAYLOAD';

cmp_ok($signer->canonical_request, 'eq', $expected_canon_request);

my $expected_string_to_sign = 'AWS4-HMAC-SHA256
20130524T000000Z
20130524/us-east-1/s3/aws4_request
1ce3217367127240f226c8c5cb89e6e2b2cbeff9a6a6bf78cbd50fb3b07eff95';

cmp_ok($signer->string_to_sign, 'eq', $expected_string_to_sign);

my $signature = 'baa9ba4567835bc469f3410235f3116036b8685c7460ead98e150e128cca84fa';
cmp_ok($signer->signature, 'eq', $signature);

my $expected_signed_qstring = 'X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIOSFODNN7EXAMPLE%2F20130524%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20130524T000000Z&X-Amz-Expires=86400&X-Amz-Security-Token=fooSessionToken9876543210&X-Amz-SignedHeaders=host&X-Amz-Signature=baa9ba4567835bc469f3410235f3116036b8685c7460ead98e150e128cca84fa';
cmp_ok($signer->signed_qstring, 'eq', $expected_signed_qstring);

$signer = Signer::AWSv4::S3->new(
time => Time::Piece->strptime('20130524T000000Z', '%Y%m%dT%H%M%SZ'),
access_key => 'AKIAIOSFODNN7EXAMPLE',
secret_key => 'wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY',
session_token => 'fooSessionToken9876543210',
method => 'GET',
key => 'test.txt',
bucket => 'examplebucket',
region => 'us-east-1',
expires => 86400,
version_id => '1234561zOnAAAJKHxVKBxxEyuy_78901j',
);

$expected_signed_qstring = 'X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIOSFODNN7EXAMPLE%2F20130524%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20130524T000000Z&X-Amz-Expires=86400&X-Amz-Security-Token=fooSessionToken9876543210&X-Amz-SignedHeaders=host&versionId=1234561zOnAAAJKHxVKBxxEyuy_78901j&X-Amz-Signature=e3677f60bb4aef0a1a75d95dcde50846ff4849e26764a602022638a18ce69a3d';
cmp_ok($signer->signed_qstring, 'eq', $expected_signed_qstring);

$signer = Signer::AWSv4::S3->new(
time => Time::Piece->strptime('20130524T000000Z', '%Y%m%dT%H%M%SZ'),
access_key => 'AKIAIOSFODNN7EXAMPLE',
secret_key => 'wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY',
session_token => 'fooSessionToken9876543210',
method => 'GET',
key => 'test.txt',
bucket => 'examplebucket',
region => 'us-east-1',
expires => 86400,
version_id => '1234561zOnAAAJKHxVKBxxEyuy_78901j',
content_type => 'text/plain',
content_disposition => 'inline; filename=New Name.txt',
);

$expected_signed_qstring = 'X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIOSFODNN7EXAMPLE%2F20130524%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20130524T000000Z&X-Amz-Expires=86400&X-Amz-Security-Token=fooSessionToken9876543210&X-Amz-SignedHeaders=host&response-content-disposition=inline%3B%20filename%3DNew%20Name.txt&response-content-type=text%2Fplain&versionId=1234561zOnAAAJKHxVKBxxEyuy_78901j&X-Amz-Signature=5ee5497a04f74c558fbb431876251834d67ed4807d17bd4b11a8418150baed7b';
cmp_ok($signer->signed_qstring, 'eq', $expected_signed_qstring);

done_testing;