Include (x64) architecture in Windows & Linux release filenames #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the architecture which we'll want to clearly later separate Windows builds for x64/arm64 much like is already done for Linux and macOS.
Instead of install.exe and osu.AppImage now we'll get install-x64.exe and osu-x64.AppImage allowing for future clean addition of arm64 files not much unlike is already the case with macOS.
6 tasks
Author
|
Now with the latest release out is this something that should even be done? Maybe it can be done just for |
Contributor
|
I would rather not have such large moving pieces so yes I agree with only doing it with arm64. However please understand that this is all of extremely low priority for us. osu! "runs" on win-arm64, and tbh that's probably good enough for that platform for now. linux-arm64 is something different but I'd also say that's an edge case too. |
Contributor
|
Also I appreciate the help but I would rather deploy stuff be left in our hands. There's a lot of small interactions (this PR for example would break the updater without compensating for the channel change). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #192 split this out as these are the changes which could also affect non-ARM64 parts of the releases. I'm not sure just how large of an effect the following release asset renames will have but if I had to guess it'll be big and should be done carefully (to accomodate the future
-arm64variants).RELEASESRELEASES-win-x64releases.win.jsonreleases.win-x64.json*-lazer-full.nupkg*-lazer-win-x64-full.nupkg*-lazer-delta.nupkg*-lazer-win-x64-delta.nupkginstall.exeinstall-x64.exeosu.AppImageosu-x64.AppImageThis will of course not potentially just affect the in-game updater but also the README, website, flatpak and possibly more I'm not even aware of yet.