Add Recursion #383
Open
Add Recursion #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laysauchoa
reviewed
Nov 13, 2020
| """ | ||
|
|
||
| def countZeros(n): | ||
| if n<0: |
There was a problem hiding this comment.
you can have an space between n < 10 as in the next line you have n == 0 with spaces ;)
laysauchoa
reviewed
Nov 13, 2020
|
|
||
| # Main | ||
| from sys import setrecursionlimit | ||
| setrecursionlimit(11000) |
There was a problem hiding this comment.
better would be set_recursion_limit name
laysauchoa
reviewed
Nov 13, 2020
| """ | ||
| --------------------------------------- Sum Of Array ------------------------------------------ | ||
|
|
||
| Given an array of length N, you need to find and return the sum of all elements of the array. |
There was a problem hiding this comment.
I like that you have docstrings explaining what you are proposing
laysauchoa
suggested changes
Nov 13, 2020
laysauchoa
left a comment
laysauchoa
left a comment
There was a problem hiding this comment.
love recursion! so I think you can lint your file because sometimes I see n=0 and sometimes n = 0 so just having a automatic linting should solve this for you.
The file names are not following the repository style and also, it is not the python convention. You should rename all to lower case with underscore style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed or what question/feature you have added.
Added Recursion questions for recursion.
Type of change
Please delete options that are not relevant.
Checklist: