Make bigdecimal an optional dependency #114
Open
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already support BigDecimal in CFF we'll keep it. That said, it seems like a very farfetched scenario. It doesn't lay in the re-encoding path. It can only be there by manually construction a CFF Dict which is a very specific an unconventionl thing to do. Anyway, since a BigDecimal can only come from the user code we'll leave it to the user to add the dependency.
pointlessone
force-pushed
the
bigdecimal
branch
from
2c5ac03 to
e2f5ab3
Compare
Fryguy
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we already support BigDecimal in CFF we'll keep it. That said, it seems like a very farfetched scenario. It doesn't lay in the re-encoding path. It can only be there by manually construction a CFF Dict which is a very specific an unconventionl thing to do. Anyway, since a BigDecimal can only come from the user code we'll leave it to the user to add the dependency.
This is an alternative solution to #108.