Skip to content

(fix) Ensure runtime and napi are emitted as needed. #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
strazzere wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(fix) Ensure runtime and napi are emitted as needed. #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bc7411
(fix) Ensure runtime and napi are emitted as needed.
strazzere Mar 7, 2024
d1d2de8
Do not emit runtime if name available
strazzere Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@ function encodeName (name) {
function prebuildName (target, opts) {
var tags = [encodeName(opts.name || target.runtime)]

if (!opts.napi) {
if (opts.napi) {
tags.push('napi')
} else {
tags.push('abi' + abi.getAbi(target.target, target.runtime))
}

Expand Down
23 changes: 23 additions & 0 deletions test/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,29 @@ test('build with current node version', function (t) {
})
})

test('runtime napi flags', function (t) {
prebuildify({
cwd: path.join(__dirname, 'package'),
targets: [{ runtime: 'node', target: process.version }],
napi: true,
tagLibc: true // Should be glibc (unless you run these tests on Alpine)
}, function (err) {
t.ifError(err)
t.doesNotThrow(function () {
var folder = os.platform() + '-' + os.arch()
var name = [
'addon',
'napi',
'glibc',
'node'
].join('.')
var addon = require(path.join(__dirname, 'package', 'prebuilds', folder, name))
t.equal(addon.check(), 'prebuildify')
})
t.end()
})
})

test('uv, armv and libc tags', function (t) {
prebuildify({
cwd: path.join(__dirname, 'package'),
Expand Down