-
Notifications
You must be signed in to change notification settings - Fork 16
Many updates and fixes #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Please note that I did release my fork to RubyGems as stackbuilders-campfire_export so that it can be more broadly used and tested. I updated the documentation on our fork to describe the fixes that have been made, and how to install the updated gem from RubyGems. If you decide to merge the changes from my fork and make a new release, I'll gladly point back to your original repo and yank my own published gem. Thanks again for this gem, which helped us to export our 1.3 GB of data from Campfire. :) |
when the XML response doesn't include a proper date, the exception handling function causes an error.
improper rescue clause caused errors when no date returned in XML from campfire.
Fix error handling when Campfire API doesn't return a proper date
|
Thanks for this fix. This is working well on Ruby 2.2.3 with El Capitan! |
|
@jqr you're welcome. Glad to hear it was helpful. :) |
Hi, thanks for this useful library.
I made several changes and fixes so that I could use this program to export a large Campfire history:
Note that after merging you should enable travis for this repo and change the README to point to your travis instance. Other than that there are no other changes that are specific to my configuration.
Please let me know if you feel ok making changes this large to the codebase and pushing a new gem. My only concern is that there isn't a ton of test support present, and my only testing of my changes is quickly visually inspecting that an export of > 1 GB looks pretty much ok.
If you're not comfortable merging this yet and pushing a new gem release, I can push this to another gem name temporarily, e.g.,
stackbuilders-campfire_export, and if there is some manually testing done by other users we can merge this into your main codebase, and push a new gem using your account when you feel comfortable that it has had enough testing. Let me know how you'd like to proceed, and thanks very much for your work on this gem which has been very useful to us @stackbuilders!