Skip to content

Conversation

@garylvov
Copy link

@garylvov garylvov commented Jan 16, 2026

Description

Successor PR to #5307 that only includes task groups, not yet external task tomls, to make the review a bit easier. I changed the format of the groups a bit relative to the previous PR in the manifest based on @bollwyvl 's suggestion, and I believe this will later make adding the external tomls cleaner.

This adds [tasks-groups] to the manifest, and associated CLI stuff to make filtering tasks easy. This also does a small sidequest to address #5276 .

After this one is merged, I will PR the external tasks toml functionality initially demo'd in #5307 . In the meantime I'll PR it within my fork for vis, but I still need to get around to that.

Fixes #4971 , #5276

How Has This Been Tested?

I tested the build release locally on a minimal example, and added some small Python and Rust tests.

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: Opus 4.5 within Claude Code 2.1.9

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py. <- I gave this a shot but am not confident I did it correctly

@garylvov garylvov marked this pull request as draft January 16, 2026 18:17
@garylvov
Copy link
Author

Local sanity check:
image
image

@garylvov garylvov marked this pull request as ready for review January 16, 2026 18:24
Copy link
Contributor

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill defer the UX design to @ruben-arts but the code looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(tasks): namespacing/grouping of tasks

3 participants