-
Notifications
You must be signed in to change notification settings - Fork 421
feat: Add Task Groups (Defer External Task Toml to Separate PR) #5318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
garylvov
wants to merge
9
commits into
prefix-dev:main
Choose a base branch
from
garylvov:groups_only
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+818
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
8 tasks
bollwyvl
reviewed
Jan 16, 2026
8 tasks
baszalmstra
approved these changes
Jan 20, 2026
Contributor
baszalmstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill defer the UX design to @ruben-arts but the code looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
Successor PR to #5307 that only includes task groups, not yet external task tomls, to make the review a bit easier. I changed the format of the groups a bit relative to the previous PR in the manifest based on @bollwyvl 's suggestion, and I believe this will later make adding the external tomls cleaner.
This adds
[tasks-groups]to the manifest, and associated CLI stuff to make filtering tasks easy. This also does a small sidequest to address #5276 .After this one is merged, I will PR the external tasks toml functionality initially demo'd in #5307 . In the meantime I'll PR it within my fork for vis, but I still need to get around to that.
Fixes #4971 , #5276
How Has This Been Tested?
I tested the build release locally on a minimal example, and added some small Python and Rust tests.
AI Disclosure
Tools: Opus 4.5 within Claude Code 2.1.9
Checklist:
schema/model.py. <- I gave this a shot but am not confident I did it correctly