feat: Add recipe_yaml configuration option for pixi-build-rattler-build #5364
+97
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
baszalmstra
added
enhancement
baszalmstra
commented
Jan 20, 2026
| } | ||
| }; | ||
|
|
||
| let variant_path = source_dir.join(VARIANTS_CONFIG_FILE); |
Contributor
Author
There was a problem hiding this comment.
Can you explain what this does? Should we not also add this to the input-globs, to make sure that if the file changes the build is retriggered?
baszalmstra
commented
Jan 20, 2026
| #[serde(default)] | ||
| pub experimental: Option<bool>, | ||
| #[serde(default)] | ||
| pub recipe_yaml: Option<PathBuf>, |
Contributor
Author
There was a problem hiding this comment.
Maybe we should call this recipe-path instead?
isuruf
reviewed
Jan 20, 2026
| } | ||
| }; | ||
|
|
||
| let variant_path = source_dir.join(VARIANTS_CONFIG_FILE); |
There was a problem hiding this comment.
Suggested change
| let variant_path = source_dir.join(VARIANTS_CONFIG_FILE); | |
| // We might have a recipe out of the source_dir given by | |
| // recipe_yaml config option. We check for variants.yaml file | |
| // inside the source_dir for configuring variants. | |
| let variant_path = source_dir.join(VARIANTS_CONFIG_FILE); |
isuruf
reviewed
Jan 20, 2026
| && variant_path.is_file() | ||
| { | ||
| variant_files.push(variant_path); | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| input_globs.insert(VARIANTS_CONFIG_FILE); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is moved from prefix-dev/pixi-build-backends#532
This PR adds support for configuring the path of the recipe.yaml relative to the source location. This is useful if the recipe has a different name.
@isuruf We moved the build backends into this repository. I manually moved all your changes over verbatim in a new commit, adding you as a co-author. I didnt make any changes.
Fixes #5251
(@lucascolley As you were mentioned in the previous PR)