-
Notifications
You must be signed in to change notification settings - Fork 421
ci: release on every push on main to backends channel #5369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The recipe files had source paths pointing to pixi-build-backends/ instead of the repository root where the crates/ directory and LICENSE file are located.
66b70e2 to
4b117bc
Compare
53f64c5 to
e6a53fd
Compare
|
Ok, that seems to be the case :) |
eb25909 to
71943b5
Compare
Yeah, but to be fair, arguably we should also release if something changed in Pixi, since the backends depend on Pixi. But then we would release a lot |
748bef3 to
187889c
Compare
8b8ea8e to
8aa7d4c
Compare
|
Doing this on every merge to main is something I turned off in the backends repo because we're dealing with heavy queues. What is the reason we would want this again? |
So people can test latest changes easily. |
e8b121c to
b63bc6c
Compare
| - "crates/pixi-build-rust/**" | ||
| - "crates/pixi-build-mojo/**" | ||
| - ".github/workflows/backends-release.yml" | ||
| pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove that before merging.
Unless it's super fast, we should maybe also only release on tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For easy testing you could make this labeled, e.g.:
on:
pull_request:
types: [ labeled ]
jobs:
build:
if: ${{ github.event.label.name == 'release:backends' }}Just an idea that came to mind, not Merge blocking ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
| unit: false | ||
| - os: windows-latest | ||
| artifact: pixi-windows-x86_64 | ||
| unit: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are unit tests not run on windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original setup only ran it on ubuntu-latest. I don't see a reason to extend that to more OS's
Description
Release backends on every push on main to backends channel
EDIT: Only happens when relevant paths are touched
How Has This Been Tested?
I ran the following locally and it looked fine. But we'll only know for sure after merging:
AI Disclosure
Tools: Claude
Checklist: