fix: Fix pixi-build-rust tests failing due to sccache #5396
+50
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not fail pixi-build-rust tests due to some tests suddenly adding sccache support into the outputr. The root cuase is that one test sets SCCACHE variables to test support for sccache in the builder, which triggers any other test running in parallel to also pick that up. This PR puts the system environment into the `RustBackendConfig`, so that tests do not need to mess with a global resource like system variables. Fixes: prefix-dev#5383
baszalmstra
reviewed
Jan 23, 2026
Good idea! Co-authored-by: Bas Zalmstra <4995967+baszalmstra@users.noreply.github.com>
baszalmstra
approved these changes
Jan 23, 2026
Contributor
|
I don't understand how that could lead to problems since cargo nextest is isolated by processes. Did you maybe use cargo test instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not fail pixi-build-rust tests due to some tests suddenly adding sccache support into the outputr.
The root cuase is that one test sets SCCACHE variables to test support for sccache in the builder, which triggers any other test running in parallel to also pick that up.
This PR puts the system environment into the
RustBackendConfig, so that tests do not need to mess with a global resource like system variables.Fixes: #5383
How Has This Been Tested?
By running the tests repeatedly in a 16 core system.
I think this still picks up the environment variables when not using tests, but I admit I did not fully understand where the "real" configuration comes from. The default-constructed configuration will have the current system environment included, so I think it is safe.
AI Disclosure
No AI was harmed during this work.
Checklist: