-
Notifications
You must be signed in to change notification settings - Fork 21
Implement working directory setup #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c106d60 to
48aa126
Compare
48aa126 to
8bf8202
Compare
pavelzw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good, a couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you create a pr in the pixi repo as well? https://github.com/prefix-dev/pixi/blob/main/docs/integration/ci/github_actions.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@pavelzw thanks for the review! I will make requested changes soon (this week or beginning of the next one) 🙂 |
|
@retrry any updates on this pr? |
- Rename pixiPathInWorkingDir to pixiTomlPathInWorkingDir - Rename pyprojectPathInWorkingDir to pyprojectTomlPathInWorkingDir - Remove untildify from relative manifest paths - Remove optional marker from execOptions parameter in executeGetOutput - Bump version to 0.9.4 - Add note in README about setting working-directory for subsequent run steps - Add working-directory tests to test.yml (basic, with relative manifest-path, and with absolute manifest-path) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update all setup-pixi version references to v0.9.4 and simplify the working-directory note example to maintain expected count. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixes: #170
Tested fork on my internal workflows - it is working correctly 🙂
If updating documentation: