UI Redesign: Sidebar Navigation & New Features #18
Conversation
- Refactored `ImageDownloaderApp` in `app/ui.py` to be a `CTkFrame`. - Created `app/sidebar_app.py` as the new entry point with Sidebar Navigation. - Implemented `BatchLinkAnalyzer` for link preview functionality. - Implemented `ClipboardMonitor` for auto-detecting URLs. - Updated `main.py` to launch the new `SidebarApp`. - Cleaned up dependencies and unused imports.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
- Enhanced `UniversalScraper` with a Selenium-based strategy for dynamic content extraction. - Added recursive crawling capabilities (`crawl_depth`) to `UniversalScraper`. - Updated `DownloaderFactory` to use `UniversalScraper` as the primary fallback. - Added UI controls for "Dynamic Mode" and "Crawl Depth" in `OptionsPanel`. - Updated `requirements.txt` with necessary dependencies (`selenium`, `webdriver-manager`).
- Research Findings: Analyzed MediaCrawler and tutorials, identified Playwright and network sniffing as key improvements for modern dynamic sites.
- Implementation:
- Added `playwright` and `httpx` to dependencies.
- Updated `UniversalScraper` with a new `_strategy_playwright_extraction` method that uses Playwright for headless browsing and network event interception (sniffing media URLs).
- Updated `DownloadOptions` in `base.py` to support `headless_browser_type` (defaulting to 'playwright') and `use_playwright` flag.
- Updated `OptionsPanel` in `app/window/options_panel.py` to expose the engine selection (Selenium vs Playwright) to the user.
- Updated `app/ui.py` to pass these new options to the downloader factory.
- Validation: Verified with existing tests.
- Fixes: Included missing dependencies (`webdriver-manager`) from previous iteration.
|
/gemlni review |
This PR introduces a major UI overhaul and two new features:
CTkFrame.These changes address
ARCH-001(UI modularization) andFEATURE-001(Batch input foundation) from the roadmap.PR created automatically by Jules for task 8660570096864686848 started by @dzp5103