-
Notifications
You must be signed in to change notification settings - Fork 1
Add Roadmap and Readme Improver Microagent #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @primoscope, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new microagent, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new microagent, roadmap_readme_improver, designed to analyze and suggest improvements for ROADMAP.md and README.md files. The agent definition is well-structured. However, the instructions for the agent are ambiguous about which files to target when multiple ROADMAP.md or README.md files exist in the repository. I've provided suggestions to make these instructions more specific to prevent the agent from acting on incorrect files, which I consider a high-severity issue given that this file defines the agent's core behavior.
| This agent does not have specific triggers and is intended to be used when general improvement of documentation is needed or when explicitly invoked by the user to check these files. | ||
|
|
||
| ## Instructions | ||
| 1. **Check Roadmap:** Look for `ROADMAP.md` or similar files. Identify items that might be completed but not marked, or areas where the roadmap can be clarified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instruction to "Look for ROADMAP.md or similar files" is ambiguous. This repository contains multiple roadmap-related files (e.g., docs/planning/ROADMAP.md and ROADMAP_COMPLETE.md). This ambiguity could lead the agent to modify an incorrect file, such as a historical report instead of the active roadmap. The instruction should be more specific to guide the agent correctly.
| 1. **Check Roadmap:** Look for `ROADMAP.md` or similar files. Identify items that might be completed but not marked, or areas where the roadmap can be clarified. | |
| 1. **Check Roadmap:** Look for the primary `ROADMAP.md` file, typically in the root or a `docs/planning` directory, distinguishing it from archival reports. Identify items that might be completed but not marked, or areas where the roadmap can be clarified. |
|
|
||
| ## Instructions | ||
| 1. **Check Roadmap:** Look for `ROADMAP.md` or similar files. Identify items that might be completed but not marked, or areas where the roadmap can be clarified. | ||
| 2. **Check Readme:** Look for `README.md` files. Ensure installation instructions, usage examples, and project descriptions are up-to-date and easy to understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, the instruction to "Look for README.md files" is ambiguous. The repository contains a main README.md in the root and another in the docs/ directory. To ensure the agent improves the main user-facing documentation, the instruction should specify targeting the root README.md file.
| 2. **Check Readme:** Look for `README.md` files. Ensure installation instructions, usage examples, and project descriptions are up-to-date and easy to understand. | |
| 2. **Check Readme:** Look for the main `README.md` file, usually in the project root. Ensure installation instructions, usage examples, and project descriptions are up-to-date and easy to understand. |
This PR adds a new microagent
roadmap_readme_improverto the.openhands/microagentsdirectory.This microagent is designed to:
ROADMAP.mdandREADME.mdfiles.The microagent does not have any specific triggers as requested.
@primoscope can click here to continue refining the PR