Skip to content

Divide login email errors to Email error and Password error #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
physphile wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Divide login email errors to Email error and Password error #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions auth_backend/auth_plugins/email.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ async def _login(cls, user_inp: EmailLogin, background_tasks: BackgroundTasks) -
.one_or_none()
)
if not query:
raise AuthFailed("Incorrect login or password", "Некорректный логин или пароль")
raise AuthFailed("Email is not registered", "Такая почта еще не зарегистрирована")
Copy link
Member

@grigoriev-semyon grigoriev-semyon Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

таким образом можно будет понять какие почты зарегестрированы и брутфорсить онли пароль

auth_params = Email.get_auth_method_params(query.user_id, session=db.session)
if auth_params["confirmed"].value.lower() == "false":
raise AuthFailed(
Expand All @@ -157,7 +157,7 @@ async def _login(cls, user_inp: EmailLogin, background_tasks: BackgroundTasks) -
auth_params["hashed_password"].value,
auth_params["salt"].value,
):
raise AuthFailed("Incorrect login or password", "Некорректный логин или пароль")
raise AuthFailed("Incorrect password", "Неправильный пароль")
userdata = await Email._convert_data_to_userdata_format({"email": auth_params["email"].value})
background_tasks.add_task(
get_kafka_producer().produce,
Expand Down