-
Notifications
You must be signed in to change notification settings - Fork 4
Union members upgrade fix. #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
💩 Code linting failed, use |
Coverage Report
Summary
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
💩 Code linting failed, use |
grigoriev-semyon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тесты норм
добавь lazy и норм
|
@dyakovri посмотри тоже пж |
| for _user in db_delete_users: | ||
| for print_fact in _user.print_facts: | ||
| db.session.delete(print_fact) | ||
| for files in _user.files: | ||
| db.session.delete(files) | ||
| db.session.delete(_user) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мы так просрем всю статистику. Так делать нельзя
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Софт делит на юзера надо сделать
grigoriev-semyon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
soft deletes
Изменения
Теперь при обновлении пользователей, если последний не был указан в запросе, то он удаляется из базы.
Реализации
Реализована проверка на то, надо ли удалять пользователя или оставлять его.
Детали
Происходит удаление пользователей с теми
id, которые не были указаны в начальном запросе.Check-List