-
Notifications
You must be signed in to change notification settings - Fork 1
создание VuInput компонента #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
не понимаю работы состояния open, т.к в active уже состояние open + как я это должен отображать в sb. |
| message: 'Номер группы', | ||
| }, | ||
| }; | ||
| export const Hover: Story = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вынеси эту историю в отдельную, типа "Validate"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А чтобы показать hover, можешь использовать pseudo. Посмотри, как это сделано в кнопке и поиске
| import VuInput from './VuInput.vue'; | ||
|
|
||
| const meta = { | ||
| title: 'Viribus Unitis/VuInput', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Подключи tags: ['autodocs'], чтобы дока сгенерировалась.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Здесь же можно дефолтные аргументы для всех историй прописать
src/components/Input/VuInput.vue
Outdated
| type: String, | ||
| default: "" | ||
| }, | ||
| color: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Поскольку у нас дизайн-система, и там всего один вариант цвета, лучше не отдавать это поле. Поставь одно значение и все
src/components/Input/VuInput.vue
Outdated
| type: String, | ||
| default: "#000000" | ||
| }, | ||
| variant: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Аналогично здесь -- в ДС всего один вариант, его и оставляем
Глянул -- вроде бы он уже на уровне либы поддерживается. так что забей. Уже все работает |
BatuevIO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Последнее исправление, потом все ок
| type: String, | ||
| default: "" | ||
| }, | ||
| variant: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вроде просил убрать -- ты только в типе заменил. Убери этот проп вообще, и впиши сразу в компонент значение
| import { PropType } from 'vue'; | ||
| type VariantType = "outlined" | "filled" | "underlined" | "plain" | "solo" | "solo-inverted" | "solo-filled" | ||
| type VariantType = "outlined" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Этот тип не нужен
No description provided.