Skip to content

Conversation

@ajungwirth
Copy link
Collaborator

No description provided.

@qligier
Copy link
Member

qligier commented Jul 4, 2022

I'll try the generation of the Swiss and Austrian code later this week.

I'm in favour of more logging but would prefer not to swallow exceptions, to break the execution if an error arises. Is it a problem for you?

@qligier
Copy link
Member

qligier commented Jul 7, 2022

The PIVL_TS issue is to be resolved in ArtDecor2JavaGenerator.adjustDataType(String, String) (line 1241). Simply add:

if (retVal.startsWith("PIVL_TS")) {
    retVal = "PIVLTS";
}

Same thing for CS.LANG -> CS

@qligier
Copy link
Member

qligier commented Jul 7, 2022

org.husky.cda.elga.generated.artdecor.ps.ELGAPatientSummary2 not generating: seems like there's an error in ArtDecor (https://art-decor.org/art-decor/decor-templates--elgaps-?section=templates&id=1.2.40.0.34.11.13.1.3&effectiveDate=2017-08-13T13:58:18&language=de-DE). The field hl7:languageCode seems to be named "hl7:languageCode " (with a space). We can fix it in the code generator but it should be fixed anyway in ArtDecor.

There may be other errors in ArtDecor. See all "is declared as list, but the XML Schema hosts it as single field" logs.

@ajungwirth
Copy link
Collaborator Author

I'll try the generation of the Swiss and Austrian code later this week.

I'm in favour of more logging but would prefer not to swallow exceptions, to break the execution if an error arises. Is it a problem for you?

It is not a problem for me, but there is still a problem with the Art Decor model. I have written an email regarding this problem with the id and the hl7:languageCode in the Art Decor.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@qligier qligier removed their assignment Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants