Make signatureMode less brittle #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, it should not assume that the Pen tool is button index 1. It should find it by type or assert otherwise.
That is, when disappearing from the view, the settor of that closure could infer from the passed PDFAnnotationController whether there are things to save, and if so, decide where/what to do or just ignore etc. Default behaviour is as before, just assigns the annotations out of the annotationController to the PDFDocument itself, then call save() on that document to archiveRootObject.
In PDFAnnotationController, and PDFAnnotationStore
Default does what it always does, calls dismiss(animated: true, completion: nil)
start up a new annotation after undoing one
better pen width and better undo functionality
- undo should still be enabled if you start an empty annotation while there are annotations in the store
fix it better
* master-uxmstudio: Update pod version Update Swift version to 4.2 # Conflicts: # Pod/Classes/Renderer/PDFViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeah I should probably squash these. Anyway - just ensures that the right Pen tool is found no matter how the view controller is configured.